Review main Merged

82772[BUGFIX] Ensure extended `XliffFileDumper::dump()` is compatible

Stefan Bürk CR +2 V +2 Easy +1 −1 updated 02/03/24, 09:20

Commit message

The `Symfony\Component\Translation\Dumper\XliffFileDumper` is extended
to add processing workflowes needed to update the xliff files based on
the ISO Database with `Build/Scripts/updateIsoDatabase.php`. Symfony 7
added method types and return types, and therefore the extended method
`dump()` needs a compatible return type.

The corresponding `:void` return type is added now.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Kevin Appelt +1
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Kevin Appelt +1
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Stefan Bürk uploaded patch set 1 02/03/24, 08:02

  2. core-ci voted on patch set 1 V +1 02/03/24, 08:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52650

  3. Anja Leichsenring voted on patch set 1 CR +1 V +1 02/03/24, 08:25

  4. Kevin Appelt voted on patch set 1 CR +1 V +1 02/03/24, 09:12

  5. Stefan Bürk voted on patch set 1 CR +2 V +2 02/03/24, 09:12

  6. Stefan Bürk merged patch set 2 02/03/24, 09:20