Review 12.4 Merged

82778[TASK] Update `doctrine/dbal:^3.8.1`

Stefan Bürk CR +2 V +2 Easy +22 −22 updated 02/06/24, 10:50

Commit message

Doctrine DBAL 3.8.x comes with further deprecations, but
also with the new `QueryBuilder::reset*()` methods as a
mitigation for the deprecated generic QueryBuilder methods
`resetQueryParams()` and `resetQueryParam()`.

See [1] for release notes and [2] for changes from current
minimum version towards 3.8.1.

Raising the minimum version ensures that extension authors
are able to create TYPO3 v12 and v13 compatible code. At least,
they can rely on it with the TYPO3 release containing this change
for non-Composer and Composer mode.

Used command(s):

> \
  composer req --no-update --no-install \
    -d typo3/sysext/redirects \
    "doctrine/dbal":"^3.8.1" ; \
  composer req --no-update --no-install \
    -d typo3/sysext/core \
    "doctrine/dbal":"^3.8.1" ; \
  composer req --no-update --no-install \
    -d typo3/sysext/install \
    "doctrine/dbal":"^3.8.1" ; \
  composer req -W \
    "doctrine/dbal":"^3.8.1"

[1] https://github.com/doctrine/dbal/releases/tag/3.8.1
[2] https://github.com/doctrine/dbal/compare/3.7.2...3.8.1

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Benni Mack +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1216

  1. Stefan Bürk uploaded patch set 1 02/04/24, 04:24

  2. core-ci voted on patch set 1 V +1 02/04/24, 04:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52676

  3. core-ci commented on patch set 1 02/04/24, 04:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52677

  4. Oliver Klee updated the commit message in patch set 2 V +1 02/04/24, 08:53

  5. Oliver Klee voted on patch set 2 CR +1 V +1 02/04/24, 08:54

  6. core-ci voted on patch set 2 V +1 02/04/24, 08:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52680

  7. Anja Leichsenring voted on patch set 2 CR +1 V +1 02/04/24, 10:04

  8. Andreas Kienast voted on patch set 2 CR +1 V +1 02/04/24, 14:03

  9. Benni Mack commented on patch set 2 02/04/24, 14:20

    Commit message: What does "full-full" mean?
    What does "full-full" mean?
  10. Stefan Bürk updated the commit message in patch set 3 CR +1 V +1 02/04/24, 19:02

  11. Stefan Bürk commented on patch set 3 02/04/24, 19:03

    Reply

    Done
  12. core-ci voted on patch set 3 V +1 02/04/24, 19:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52694

  13. Oliver Klee voted on patch set 3 CR +1 V +1 02/04/24, 20:09

  14. Benni Mack voted on patch set 3 CR +1 V +1 02/06/24, 10:29

  15. Stefan Bürk voted on patch set 3 CR +2 V +2 02/06/24, 10:50

  16. Stefan Bürk merged patch set 4 02/06/24, 10:50