Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.

Review main Work in progress Orphaned

82779[FEATURE] Mark redirects with inaccessible pages

Guido Schmechel CR -1 V +1 Normal +223 −7 updated 03/30/26, 14:14

Commit message

Redirects with a target that is an inaccessible page will be marked to
show this conflict in the redirect backend module.

Pages that are inaccessible are searched for using the "hidden",
"starttime" and "endtime" fields.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 11
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/79/82779/11 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/79/82779/11 && git cherry-pick FETCH_HEAD

Review

  • Code review CR -1 Needs a vote
    • Georg Ringer +1
    • Stefan Bürk -1
  • Verified V +1 Needs a vote
    • Josef Glatz +1
    • Georg Ringer +1
    • core-ci +1 CI

Issues 1

Files 9

Review log 2536

Show 711 earlier messages
  1. Guido Schmechel uploaded patch set 1 02/04/24, 10:24

  2. core-ci voted on patch set 1 V -1 02/04/24, 10:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52683

  3. Guido Schmechel uploaded patch set 2 V -1 02/04/24, 12:02

  4. core-ci voted on patch set 2 V +1 02/04/24, 12:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52684

  5. Guido Schmechel uploaded patch set 3 V +1 02/15/24, 15:34

  6. core-ci voted on patch set 3 V +1 02/15/24, 15:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53236

  7. Guido Schmechel commented on patch set 3 CR -1 02/15/24, 15:46

    Please do not review the patch. It is on a longer EXT:redirect agenda for clarification with Stefan Bürk. Open questions: - Chunk method - Code quality
  8. Benni Mack marked it work in progress 01/08/25, 15:57

  9. Guido Schmechel uploaded patch set 4 CR -1 V +1 01/19/25, 15:47

  10. core-ci voted on patch set 4 V +1 01/19/25, 15:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72683

  11. Benni Mack wrote 03/22/25, 16:52

    Topic set to redirects
  1. Benni Mack commented on patch set 4 03/10/26, 16:36

    hey guido. I think this is very valuable, how about we make a "inaccessible target" in this, and also consider starttime / endtime with it?
  2. Guido Schmechel uploaded patch set 5 V +1 03/14/26, 09:04

  3. core-ci voted on patch set 5 V -1 03/14/26, 09:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97939

  4. Guido Schmechel uploaded patch set 6 V -1 03/14/26, 09:13

  5. core-ci voted on patch set 6 V +1 03/14/26, 09:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97940

  6. Guido Schmechel uploaded patch set 7 V +1 03/14/26, 11:54

  7. Guido Schmechel uploaded patch set 8 03/14/26, 11:57

  8. core-ci voted on patch set 8 V +1 03/14/26, 12:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97942

  9. core-ci voted on patch set 7 V +1 03/14/26, 12:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97941

  10. Guido Schmechel marked it ready for review 03/14/26, 12:59

  11. Guido Schmechel uploaded patch set 9 V +1 03/14/26, 14:04

  12. core-ci voted on patch set 9 V +1 03/14/26, 14:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97943

  13. Josef Glatz updated the commit message in patch set 10 V +1 03/16/26, 11:56

  14. core-ci voted on patch set 10 V +1 03/16/26, 12:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98013

  15. Simon Schaufelberger uploaded patch set 11 V +1 03/28/26, 13:08

  16. core-ci voted on patch set 11 V +1 03/28/26, 13:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98958

  17. Simon Schaufelberger voted on patch set 11 CR +1 V +1 03/28/26, 13:19

  18. Georg Ringer voted on patch set 11 CR +1 V +1 03/29/26, 09:33

  19. Josef Glatz voted on patch set 11 V +1 03/30/26, 07:20

  20. Stefan Bürk commented on patch set 11 CR -1 03/30/26, 10:40

    RedirectRepository.php:496 Unresolved

    Instead of fetching all rows and returning them as array I would return the query result object instead so the surrounding code can do a while() loop.

    IntegrityService.php:78 Unresolved

    I would not reset them upfront and simply activating possible brogen redirects again. I guess we should allow rechecking already flagged targets beside all and in case it was flag and is now accessible remove it on a per usage case.

    IntegrityService.php:80 Unresolved

    I'd say the whole command / service is becomming a real memory-eating monster.

    IntegrityService.php:81 Unresolved

    Why do we build a assoc array with the redirects uid here using array_combine and array column ? I would really like to have a refactoring of the whole implementation here: * findRedirectsByTarget() should return the result object and doing while loop here * in the loop the additional checks can be processes like calling the resulve method. * I would also combine the later inaccessible check in the loop for the single item * Also the "filtering" can be done as condition in the loop. * Directly yield for each item the result instead of composing multiple possible huge arrays and lookups. The code may work, but it's kind of wasting a lot of resources here. And the connected checks and parts are not really connected.

    IntegrityService.php:216 Unresolved

    This chunking does not make much sense here. It creates mutliple IN() conditions pased on chunks and max bind parametes but have them still in one query ... that means that if the number of $pageUidList entries exceeds the $maxBindParametrs - 10 and builds two IN() conditions with parameters it still exceeds the maxBindParameters limit of the query. Chunking logic makes only sense to execute the query per chunk and combine the result afterwards. Another possible solution or peace of the solution could be to use "QueryBuilder::quoteArrayBasedValueListToIntegerList()" instead to avoid the usage of placeholders for the in query part.

    IntegrityService.php:226 Unresolved

    I guess we should not use hardcodes column identifiers and resort to TcaSchema information - even for core managed table. same for starttime and endtime below
  21. Guido Schmechel commented on patch set 11 03/30/26, 10:48

    Stefan has provided her with detailed feedback (thanks :-)) and, due to time constraints, the patch won't make it into v14 in its current form. In the meantime, it makes sense to focus on https://review.typo3.org/c/Packages/TYPO3.CMS/+/92984. This way, v14 would at least have the option of checking hidden pages during redirects using an event.
  22. Stefan Bürk commented on patch set 11 03/30/26, 11:13

    Reply

    Sorry - did't found the time earlier :/ Having a look on the other change now.
  23. Simon Schaufelberger voted on patch set 11 CR 0 V 0 03/30/26, 12:23

  24. Guido Schmechel marked it work in progress 03/30/26, 14:03

  25. Stefan Bürk commented on patch set 11 03/30/26, 14:14

    Reply

    I worked on the mentioned change. In case we get that in, I'd say this can already be done as a extension and the extension working as an incubator - and we add that in v15 as eventlistener instead of a custom implementation if possible. At least rough thinking - not sure if that pays out, but the changes are high.