Review main Abandoned

82780[WIP][FEATURE] Mark duplicate redirects

Guido Schmechel CR -1 V 0 Normal +110 −1 updated 11/13/26, 11:45

Commit message

Duplicate redirects (source_path) are marked via the integrity check
and can be filtered in the redirect backend module.

TODO:
- RST
- Tests

Review

  • Code review CR -1
    • Guido Schmechel -1
  • Verified V 0
    • core-ci +1 CI

Issues 1

Files 6

Review log 1317

  1. Guido Schmechel uploaded patch set 1 02/04/24, 12:44

  2. core-ci voted on patch set 1 V -1 02/04/24, 12:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52685

  3. Patrick Schriner commented on patch set 1 CR -1 02/05/24, 13:24

    This approach of running an SQL query for each redirect is super expensive. It's very cheap to find *all* duplicates via SQL: SELECT sr.uid, sr2.uid FROM sys_redirect sr , sys_redirect sr2 WHERE sr.source_host = sr2.source_host AND sr.source_path = sr2.source_path AND sr.uid < sr2.uid; + enableFields.
  4. Guido Schmechel commented on patch set 1 02/05/24, 13:49

    Reply Unresolved

    Hi Patrick, thank you. I'm talking to Stefan Bürk about the topic tonight. We'll take your feedback on board then. But he already had the topic of SQL ;-)
  5. Guido Schmechel uploaded patch set 2 CR -1 V -1 02/14/24, 14:42

  6. core-ci voted on patch set 2 V -1 02/14/24, 14:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53197

  7. Guido Schmechel voted on patch set 2 CR -1 02/14/24, 15:14

  8. Guido Schmechel uploaded patch set 3 CR -1 V -1 02/15/24, 11:53

  9. core-ci voted on patch set 3 V +1 02/15/24, 11:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53229

  10. Guido Schmechel commented on patch set 3 CR -1 02/15/24, 12:08

    Please do not review the patch. It is on a longer EXT:redirect agenda for clarification with Stefan Bürk. Open questions: With 3 redirects, two duplicates are marked with the current SQL. Do we have to mark all 3 in order to see the conflicts clearly in the backend? Current modified SQL: SELECT sr.uid as baseUid, sr2.uid, sr.target, sr.source_host, sr.source_path FROM sys_redirect sr INNER JOIN sys_redirect sr2 ON (sr.source_host = sr2.source_host OR sr2.source_host = "*") AND sr.source_path = sr2.source_path AND sr.uid <> sr2.uid;
  11. Guido Schmechel uploaded patch set 4 CR -1 V +1 01/19/25, 15:21

  12. core-ci voted on patch set 4 V +1 01/19/25, 15:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72681

  13. Guido Schmechel voted on patch set 4 CR -1 01/19/25, 16:04

  14. Benni Mack marked it work in progress 03/22/25, 14:16

  15. Benni Mack wrote 03/22/25, 16:53

    Topic set to redirects
  16. Stefan Bürk commented on patch set 4 03/30/26, 14:18

    Reply Unresolved

    Time went by and we missed each other - and at some point it moved way down on my own list. Hey @guido.schmechel@brandung.de - maybe this can be done with an incubator extensions based on the even of 92984: [FEATURE] Add PSR-14 event for redirect integrity checks | https://review.typo3.org/c/Packages/TYPO3.CMS/+/92984 if we can get that change merged in v14 - and implement it in v15 as core eventlistener. Would you possiblebe up for such a incubator extension ? (possible together) - otherwise I will try tocome up with one after 14LTS. Similar to 82779: [FEATURE] Mark redirects with inaccessible pages | https://review.typo3.org/c/Packages/TYPO3.CMS/+/82779 which could possible also be done in the same incubator extension based on the event and possible other checks. What do you think ?
  17. Benni Mack abandoned the change 11/13/26, 11:45