Review main Merged

82781[TASK] Update `alwan` to 2.0.2

Andreas Kienast CR +2 V +2 Easy +6 −6 updated 02/09/24, 07:07

Commit message

Executed commands:

    npm install --save alwan@^2.0.2
    npm run build

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Andreas Nedbal +1
    • Oliver Klee +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Andreas Nedbal +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1416

  1. Andreas Kienast uploaded patch set 1 02/04/24, 15:18

  2. core-ci voted on patch set 1 V +1 02/04/24, 15:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52686

  3. Oliver Klee voted on patch set 1 CR +1 02/04/24, 20:11

  4. Benni Mack voted on patch set 1 CR +1 V +1 02/06/24, 10:32

  5. Simon Schaufelberger voted on patch set 1 CR +1 V +1 02/07/24, 12:35

  6. Andreas Kienast updated the commit message in patch set 2 CR +1 V +1 02/07/24, 12:38

  7. Simon Schaufelberger voted on patch set 2 CR +1 V +1 02/07/24, 12:41

  8. Simon Schaufelberger commented on patch set 2 02/07/24, 12:42

    What does this package actually do?
  9. core-ci voted on patch set 2 V +1 02/07/24, 12:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52859

  10. Simon Schaufelberger commented on patch set 2 02/07/24, 12:44

    Reply

    ok, it's a color picker.
  11. Andreas Kienast commented on patch set 2 02/07/24, 12:56

    Reply

    How were you able to verify the patch in the first place?
  12. Oliver Klee voted on patch set 2 CR +1 02/07/24, 12:56

  13. Simon Schaufelberger commented on patch set 2 02/07/24, 13:09

    Reply

    I trust you that you have tested it well enough.
  14. Andreas Nedbal voted on patch set 2 CR +1 V +1 02/07/24, 22:50

  15. Benjamin Franzke voted on patch set 2 CR +2 V +2 02/09/24, 07:07

  16. Benjamin Franzke merged patch set 3 02/09/24, 07:07