Review main Merged

82789[TASK] Switch to Doctrine DBAL 4 comparison

Stefan Bürk CR +2 V +2 Normal +0 −155 updated 08/08/24, 18:40

Commit message

With #102875 Doctrine DBAL has been upgraded to the
`Doctrine DBAL v4` major version, keeping the column
comparison from Doctrine DBAL 3. This was done by cloning
the old DBAL code into the TYPO3 Core's `Comparator`,
waiting for several issues with comparisons to be
mitigated.

A series of pre-patches now allows to remove the old code
and switch to `AbstractPlatform::columnsEqual()`, using
the native Doctrine DBAL v4 implementation with schema
normalizations.

This change now removes these `Comparator` methods:

    * columnsEqual()
    * doctrineDbalMajorThreeDiffColumn()
    * typo3DiffColumn()

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 5

Files 1

Review log 1320

  1. Stefan Bürk uploaded patch set 1 02/05/24, 10:53

  2. core-ci voted on patch set 1 V -1 02/05/24, 10:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52714

  3. Stefan Bürk uploaded patch set 2 V -1 02/05/24, 11:52

  4. core-ci voted on patch set 2 V -1 02/05/24, 12:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52720

  5. Stefan Bürk abandoned the change 08/06/24, 15:31

  6. Stefan Bürk restored the change 08/08/24, 12:46

  7. Stefan Bürk uploaded patch set 3 V -1 08/08/24, 12:46

  8. Stefan Bürk wrote 08/08/24, 12:52

    Topic set to doctrine/dbal
  9. core-ci voted on patch set 3 V +1 08/08/24, 12:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63050

  10. Stefan Bürk uploaded patch set 4 08/08/24, 15:28

    Copied Votes: * Verified+1 (copy condition: "**changekind:NO_CHANGE**")
  11. Stefan Bürk updated the commit message in patch set 5 V +1 08/08/24, 15:30

  12. core-ci voted on patch set 4 V +1 08/08/24, 15:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63057

  13. core-ci voted on patch set 5 V +1 08/08/24, 15:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63059

  14. Garvin Hicking updated the commit message in patch set 6 V +1 08/08/24, 17:55

  15. core-ci voted on patch set 6 V +1 08/08/24, 18:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63072

  16. Christian Kuhn uploaded patch set 7 V +1 08/08/24, 18:32

  17. Anja Leichsenring voted on patch set 7 CR +1 V +1 08/08/24, 18:33

  18. core-ci voted on patch set 7 V +1 08/08/24, 18:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63078

  19. Christian Kuhn voted on patch set 7 CR +2 V +2 08/08/24, 18:40

  20. Christian Kuhn merged patch set 8 08/08/24, 18:40