Review main Merged

82791[BUGFIX] Install Tool: Load renderable components in correct scope

Andreas Kienast CR +2 V +2 Normal +84 −62 updated 02/09/24, 12:21

Commit message

Lit elements need to get created in the correct browser scope
(i.e. frame) to get rendered in Firefox, which is a huge issue in
modals (that reside in the global scope), that are triggered in an
iframe scope.

This commit introduces a helper method `loadModuleFrameAgnostic()` that
loads the module depending on the context the Install Tool is in
(standalone vs. iframe).

All Install Tool modules are modified to load renderable modules (info
boxes, flash messages and progress bars) explicitly. Also, a superfluous
progress bar is removed from the "Directory status" module that breaks
the whole modal in case a user prefers reduced motions.

Review

  • Code review CR +2 Done
    • Andreas Nedbal +2
    • Benjamin Franzke +1
  • Verified V +2 Done
    • Andreas Nedbal +2
    • Benjamin Franzke +1
    • core-ci +1 CI

Issues 1

Files 32

Show 12 more files

Review log 914

  1. Andreas Kienast uploaded patch set 1 02/05/24, 14:41

  2. core-ci voted on patch set 1 V +1 02/05/24, 14:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52735

  3. Andreas Kienast uploaded patch set 2 V +1 02/06/24, 09:44

  4. core-ci voted on patch set 2 V +1 02/06/24, 09:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52762

  5. Andreas Kienast uploaded patch set 3 V +1 02/06/24, 10:00

  6. Andreas Kienast uploaded patch set 4 02/06/24, 10:02

  7. core-ci voted on patch set 3 V +1 02/06/24, 10:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52763

  8. core-ci voted on patch set 4 V +1 02/06/24, 10:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52764

  9. Andreas Nedbal commented on patch set 4 CR +1 V +1 02/07/24, 22:43

    Checked in Chrome 121 and Firefox 122 on Windows, working fine!
  10. Andreas Kienast uploaded patch set 5 CR +1 V +1 02/09/24, 09:27

  11. core-ci voted on patch set 5 V +1 02/09/24, 09:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52944

  12. Benjamin Franzke voted on patch set 5 CR +1 V +1 02/09/24, 10:01

  13. Andreas Nedbal voted on patch set 5 CR +2 V +2 02/09/24, 12:21

  14. Andreas Nedbal merged patch set 6 02/09/24, 12:21