82792[BUGFIX] Undefined array index for TCA without ctrl
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
-
Verified V +2 Done
- Stefan Bürk +2
- core-ci +1 CI
Issues 1
Files 8
- typo3/sysext/extbase/Classes/Persistence/Generic/Storage/Typo3DbQueryParser.php+19 −18
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Classes/Domain/Model/RegistryEntry.phpnew+38 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Classes/Domain/Repository/RegistryEntryRepository.phpnew+25 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Configuration/TCA/tx_blogexample_domain_model_registryentry.phpnew+14 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Configuration/Services.yaml+3 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Resources/Private/Language/locallang_db.xlf+3 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/ext_tables.sql+7 −0
- typo3/sysext/extbase/Tests/Functional/Persistence/Generic/Storage/Typo3DbQueryParserTest.phpnew+55 −0
Review log 58
-
Stefan Bürk uploaded patch set 1 02/05/24, 14:51
-
Christian Kuhn commented on patch set 1 02/05/24, 14:56
the other option is to enforce at least an empty 'ctrl' array in TcaPreparation. this way, we don't need runtime checks at all. what do you think? -
core-ci voted on patch set 1 V -1 02/05/24, 15:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52738
-
Stefan Bürk commented on patch set 1 02/05/24, 15:06
Reply
There are no really new checks - just made them save. Creating a empty ctrl table if missing would avoid the early returns. Not sure. -
core-ci commented on patch set 1 02/05/24, 15:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52738
-
core-ci voted on patch set 1 V +1 02/05/24, 15:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52738
-
Stefan Bürk voted on patch set 1 CR +2 V +2 02/07/24, 16:22
-
Stefan Bürk merged patch set 2 02/07/24, 16:22