Review 11.5 Merged

82792[BUGFIX] Undefined array index for TCA without ctrl

Stefan Bürk CR +2 V +2 Normal +164 −18 updated 02/07/24, 16:22

Commit message

A new test case is added to cover the case when a TCA definition exists
without `ctrl`. The test case has been added to the test extension
`blog_example` which is not part of the public extension.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 8

Review log 58

  1. Stefan Bürk uploaded patch set 1 02/05/24, 14:51

  2. Christian Kuhn commented on patch set 1 02/05/24, 14:56

    the other option is to enforce at least an empty 'ctrl' array in TcaPreparation. this way, we don't need runtime checks at all. what do you think?
  3. core-ci voted on patch set 1 V -1 02/05/24, 15:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52738

  4. Stefan Bürk commented on patch set 1 02/05/24, 15:06

    Reply

    There are no really new checks - just made them save. Creating a empty ctrl table if missing would avoid the early returns. Not sure.
  5. core-ci commented on patch set 1 02/05/24, 15:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52738

  6. core-ci voted on patch set 1 V +1 02/05/24, 15:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52738

  7. Stefan Bürk voted on patch set 1 CR +2 V +2 02/07/24, 16:22

  8. Stefan Bürk merged patch set 2 02/07/24, 16:22