Review 11.5 Merged

82793[BUGFIX] Mitigate a TypeError in `StandardContentPreviewRenderer`

TYPO3com CR +2 V +2 Easy +1 −1 updated 02/09/24, 22:19

Commit message

An editor can trigger a TypeError exception leading to a 503 error
message `trim() expects parameter 1 to be string, null given` in
the backend page module by creating `menu_categorized_content`
objects with `selected_categories` and then turning them into
`menu_section` objects.

This change mitigates the type error by using a null-coalesce
fallback passing an invalid type to the `trim()` method in
`StandardContentPreviewRenderer::generateListForMenuContentTypes()`.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 59

  1. TYPO3com uploaded patch set 1 02/05/24, 14:53

  2. core-ci voted on patch set 1 V +1 02/05/24, 15:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52739

  3. Stefan Bürk commented on patch set 1 CR -1 02/05/24, 15:43

    on it ...
  4. Stefan Bürk commented on patch set 1 02/05/24, 16:15

    modified this change and started from main. leaving -1 on this until the normal backport during merge is done.
  5. Stefan Bürk uploaded patch set 2 CR -1 V +1 02/09/24, 22:00

  6. core-ci voted on patch set 2 V -1 02/09/24, 22:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52993

  7. core-ci voted on patch set 2 V +1 02/09/24, 22:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52993

  8. Stefan Bürk voted on patch set 2 CR +2 V +2 02/09/24, 22:19

  9. Stefan Bürk merged patch set 3 02/09/24, 22:19