82794[BUGFIX] Mitigate a TypeError in `StandardContentPreviewRenderer`
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Benjamin Franzke +1
- Oli Bartsch +1
- Oliver Klee +1
- Christian Kuhn +1
-
Verified V +2 Done
- Stefan Bürk +2
- Benjamin Franzke +1
- Oli Bartsch +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 1
Review log 2025
-
Stefan Bürk uploaded patch set 1 02/05/24, 16:14
-
core-ci voted on patch set 1 V +1 02/05/24, 16:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52744
-
Oliver Klee voted on patch set 1 CR +1 02/05/24, 17:44
-
Benjamin Franzke commented on patch set 1 CR -1 02/06/24, 05:11
-
Simon Schaufelberger commented on patch set 1 02/06/24, 07:03
An editor -
Stefan Bürk uploaded patch set 2
CR +1V +102/06/24, 08:35 -
Stefan Bürk updated the commit message in patch set 3 02/06/24, 08:37
-
Stefan Bürk commented on patch set 3 02/06/24, 08:37
Reply
DoneStandardContentPreviewRenderer.php:338ReplyDone -
core-ci voted on patch set 2 V +1 02/06/24, 08:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52758
-
core-ci voted on patch set 3 V +1 02/06/24, 08:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52760
-
Oli Bartsch commented on patch set 3 02/06/24, 14:49
StandardContentPreviewRenderer.php:338Why do we remove the `trim()`? This seems like a change in behaviour. -
Stefan Bürk commented on patch set 4
V +102/06/24, 16:21Published edit on patch set 3. -
Stefan Bürk commented on patch set 4 02/06/24, 16:22
StandardContentPreviewRenderer.php:338Replyunitended - was the "revert" back related to comment from Benjamin. -
Oliver Klee voted on patch set 4 CR +1 02/06/24, 16:24
-
Oli Bartsch commented on patch set 4 02/06/24, 16:25
Could the commit message also be updated as there is no more string cast done? -
Stefan Bürk updated the commit message in patch set 5
CR +102/06/24, 16:27 -
core-ci voted on patch set 4 V +1 02/06/24, 16:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52802
-
Stefan Bürk commented on patch set 5 02/06/24, 16:27
Reply
Done -
core-ci voted on patch set 5 V +1 02/06/24, 16:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52803
-
Oliver Klee voted on patch set 5 CR +1 02/06/24, 16:38
-
Benjamin Franzke voted on patch set 5 CR +1 V +1 02/09/24, 12:23
-
Christian Kuhn voted on patch set 5 CR +1 V +1 02/09/24, 12:28
-
Oli Bartsch voted on patch set 5 CR +1 V +1 02/09/24, 17:37
-
Stefan Bürk voted on patch set 5 CR +2 V +2 02/09/24, 21:59
-
Stefan Bürk merged patch set 6 02/09/24, 22:19
StandardContentPreviewRenderer.php:338