82814[BUGFIX] Properly resolve GET parameter `id`
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Oliver Klee +1
- Benni Mack +1
-
Verified V +2 Done
- Stefan Bürk +2
- Oliver Klee +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 4
Review log 2328
Show 23 earlier messages
-
Benni Mack uploaded patch set 1 02/06/24, 09:07
-
core-ci voted on patch set 1 V +1 02/06/24, 09:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52761
-
Stefan Bürk commented on patch set 1 CR -1 02/06/24, 09:22
on it ...
-
Mathias Brodala commented on patch set 1 02/06/24, 09:23
I'd vote for throwing a 404 since otherwise you have duplicate content without any option to prevent it. (Aside from e.g. adding a custom middleware, etc.) I'd also not make this configurable since it's basically the same as requesting a page ID which is hidden/deleted/etc. -
Benni Mack commented on patch set 1 02/06/24, 09:42
Reply
I agree! -
Stefan Bürk commented on patch set 1 02/06/24, 09:57
Reply
I already changed the condition to get the 404 just plumbing tests around it. Will push shortly -
Stefan Bürk commented on patch set 1 02/06/24, 10:00
Reply
At least on the page resolving - not sure on the siteconfiguration part. There I would not resolve it based on the given id so we have at least the current matched domain error handler configuration in place. What do you think ? -
Stefan Bürk uploaded patch set 2
CR -1V +102/06/24, 10:05 -
core-ci voted on patch set 2 V +1 02/06/24, 10:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52765
-
Mathias Brodala commented on patch set 2 02/06/24, 10:17
PageRouter.php:111Hm, isn't this a change of behavior? So far if requestId was exactly 0, then there was no direct throw here. The code below would take over instead. It makes sense to stop early, but still ...SiteRequestTest.php:1066We should also have a test for 0 (integer) here then.SiteRequestTest.php:1079"exponent"? -
Stefan Bürk commented on patch set 2 02/06/24, 10:41
PageRouter.php:111ReplyThe whole bugfix is basically a change in behaviour, and a explicitly defined ? id=0 is invalid like id=foobar - so I would take it now the same way. And not introducing a additional special handling for it. In the end, the whole ?id= handling must die in v14.0.SiteRequestTest.php:1066Reply> We should also have a test for 0 (integer) here then. ack. -
Stefan Bürk uploaded patch set 3
V +102/06/24, 10:42 -
Stefan Bürk commented on patch set 3 02/06/24, 10:42
SiteRequestTest.php:1066ReplyDoneSiteRequestTest.php:1079ReplyDone -
core-ci voted on patch set 3 V +1 02/06/24, 10:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52766
-
Mathias Brodala commented on patch set 3 02/06/24, 10:53
PageRouter.php:111ReplyAcknowledged -
Stefan Bürk commented on patch set 3 02/06/24, 16:23
Reply
Done -
Oliver Klee voted on patch set 3 CR +1 V +1 02/06/24, 16:30
-
Stefan Bürk voted on patch set 3 CR +1 V +1 02/06/24, 16:41
-
Simon Schaufelberger commented on patch set 3 02/08/24, 00:31
why not just `id`?an integer...anthis sentence is a bit weird to read. -
Stefan Bürk updated the commit message in patch set 4
CR +1V +102/08/24, 03:25 -
Stefan Bürk updated the commit message in patch set 5 02/08/24, 03:26
-
core-ci voted on patch set 4 V +1 02/08/24, 03:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52874
-
core-ci voted on patch set 5 V +1 02/08/24, 03:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52875
-
Oliver Klee voted on patch set 5 CR +1 V +1 02/08/24, 08:52
-
Benni Mack voted on patch set 5 CR +1 V +1 02/08/24, 20:48
-
Stefan Bürk voted on patch set 5 CR +2 V +2 02/09/24, 06:29
-
Stefan Bürk merged patch set 6 02/09/24, 06:44