Review main Merged

82815[BUGFIX] Install Tool: Re-enable modal actions after execution

Andreas Kienast CR +2 V +2 Hard +212 −197 updated 02/09/24, 09:21

Commit message

In some cases it was missed to enable modal actions again after their
execution in the Install Tool. This patch adds the necessary statements
to enable said buttons again.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Garvin Hicking +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 21

Show 1 more file

Review log 2634

Show 69 earlier messages
  1. Andreas Kienast uploaded patch set 1 02/06/24, 10:47

  2. core-ci voted on patch set 1 V -1 02/06/24, 10:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52767

  3. Andreas Kienast uploaded patch set 2 V -1 02/06/24, 11:11

  4. core-ci voted on patch set 2 V -1 02/06/24, 11:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52771

  5. Andreas Kienast uploaded patch set 3 V -1 02/06/24, 11:25

  6. core-ci voted on patch set 3 V +1 02/06/24, 11:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52773

  7. Garvin Hicking commented on patch set 3 02/06/24, 12:21

    Great work on this, thanks so much for adressing it! I tested the following places. I always opened the modal, then made the `config/system/additiona.php` to contain a PHP parse error, plus flushed the cache. Then tried to execute the action button(s) in the modal and verified that a returned error was a) shown and b) allowed me to re-execute the button after that. This is where it worked well, and showed an error message properly: * Admin-Tools > Environment > Check Environment... * Admin-Tools > Environment > Send test mail... * Admin-Tools > Settings > Change Install Tool Password... * Admin-Tools > Settings > Manage System Maintainers... * Admin-Tools > Settings > Choose Preset... * Admin-Tools > Settings > Configure Features... * Admin-Tools > Settings > Configure options... * Admin-Tools > Maintenance > Scan temporary files... * Admin-Tools > Maintenance > Scan tables... * Admin-Tools > Maintenance > Create Administrator... * Admin-Tools > Upgrade > Run Upgrade Wizard This is where it worked, however no error was shown (outside the scope of this PR?, just to note this): * Admin-Tools > Environment > Test Images... * Admin-Tools > Upgrade > Check TCA Migrations... This is where it doesn't yet work (not covered by this PR?): * Admin-Tools > Environment > Check Directory Status... * Admin-Tools > Maintenance > Analyze database ... (buttons don't get re-enabled) * Admin-Tools > Upgrade > Check TCA... (button doesn't get re-enabled) * Admin-Tools > Upgrade > Check Extension Compatibility... (button doesn't get re-enabled) * Admin-Tools > Upgrade > Scan Extension Files... (button doesn't get re-enabled, two error popups get shown instead of one)
  8. Andreas Kienast commented on patch set 3 V -1 02/06/24, 13:13

    Reply

    Thank you for your tests > Admin-Tools > Environment > Check Directory Status... This only has a "fix me" button, no re-check button > Admin-Tools > Maintenance > Analyze database > Admin-Tools > Upgrade > Check Extension Compatibility > Admin-Tools > Upgrade > Scan Extension Files Cannot reproduce. Which Install Tool mode did you test in which browser? Also, did you make sure you've cleared your caches? > Admin-Tools > Upgrade > Check TCA Confirmed
  9. Andreas Kienast uploaded patch set 4 V +1 02/06/24, 13:14

  1. core-ci voted on patch set 4 V +1 02/06/24, 13:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52780

  2. Garvin Hicking commented on patch set 4 02/06/24, 16:15

    Reply

    About the "fix me" Button: Yes, if I click the button (while the "parse error" is active) the button permanently stays disabled. So once I fix the parse error I cannot hit the button again without reloading the backend too. About the three non-reproducible issues for you, I'll try to show you tomorrow (see slack). Used Chromium macOS.
  3. Andreas Kienast commented on patch set 4 CR -1 02/07/24, 07:43

    on it
  4. Andreas Kienast uploaded patch set 5 CR -1 V +1 02/07/24, 08:43

  5. Andreas Kienast commented on patch set 5 02/07/24, 08:45

    Reply

    Done
  6. core-ci voted on patch set 5 V +1 02/07/24, 08:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52832

  7. Garvin Hicking commented on patch set 5 02/07/24, 09:11

    Reply

    Oh yes, this is awesome. Thanks for addressing it!! Works now: * Admin-Tools > Upgrade > Check TCA Migrations... * Admin-Tools > Environment > Check Directory Status... * Admin-Tools > Maintenance > Analyze database ... * Admin-Tools > Upgrade > Scan Extension Files... (Tested this mainly in the embedded section of the normal backend, only superficially tested this in the "standalone" /typo3/installer.php, but I'm "feeling lucky" that it should all work the same there) One single thing remains for me: "Admin-Tools > Upgrade > Check Extension Compatibility... " The button now gets re-enabled, but re-clicking it doesn't re-execute the task even when the additional.php error is fixed). In all other modules re-executing the button leads to the functionality getting available again.
  8. Andreas Kienast uploaded patch set 6 V +1 02/07/24, 09:27

  9. Andreas Kienast commented on patch set 6 02/07/24, 09:27

    Reply

    Done
  10. core-ci voted on patch set 6 V +1 02/07/24, 09:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52837

  11. Garvin Hicking commented on patch set 6 CR +1 V +1 02/07/24, 09:35

    Flawless victory. 👌🏻
  12. Benjamin Franzke commented on patch set 6 02/07/24, 09:45

    extension-scanner.ts:213

    Hm, would like to avoid `any`. maybe use `Promise<void>` and later only call `resolve()`? (Or make it `boolean`…)
  13. Andreas Kienast commented on patch set 6 02/07/24, 10:22

    extension-scanner.ts:213 Reply

    I also return strings in the promises, but I agree it's not pretty.
  14. Benjamin Franzke commented on patch set 6 02/07/24, 10:26

    extension-scanner.ts:213 Reply

    but you pass strings only to reject() - typescript doesn't care about that for the promise type 😄
  15. Andreas Kienast uploaded patch set 7 CR +1 V +1 02/07/24, 10:27

  16. core-ci voted on patch set 7 V +1 02/07/24, 10:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52844

  17. Benjamin Franzke commented on patch set 7 CR -1 02/07/24, 11:54

    on it

    extension-scanner.ts:213 Reply

    Done

    extension-scanner.ts:356

    I think this needs to be ``` if (doneFiles === numberOfFiles) { resolve(); ``` Otherwise the first failing file would reenable the button before others are finished. Ideally the AjaxQueue would be wrapped in separates promises which're then `Promise.allSettled` as well. Will work on that.
  18. Andreas Kienast commented on patch set 7 02/07/24, 12:02

    extension-scanner.ts:356 Reply

    Thanks! I wonder whether it makes sense to extract this little refactoring into a pre-patch.
  19. Benjamin Franzke uploaded patch set 8 CR -1 V +1 02/07/24, 12:05

  20. Benjamin Franzke commented on patch set 8 02/07/24, 12:07

    extension-scanner.ts:356 Reply

    Pushed now, not sure regarding pre-patch or not. Fine with me to include this here.
  21. core-ci voted on patch set 8 V +1 02/07/24, 12:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52853

  22. Benni Mack commented on patch set 8 02/08/24, 22:14

    extension-scanner.ts:115 Unresolved

    love that one!
  23. Garvin Hicking voted on patch set 8 CR +1 V +1 02/09/24, 08:30

  24. Andreas Kienast voted on patch set 8 CR +2 V +2 02/09/24, 09:21

  25. Andreas Kienast merged patch set 9 02/09/24, 09:21