82815[BUGFIX] Install Tool: Re-enable modal actions after execution
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Benjamin Franzke +1
- Garvin Hicking +1
-
Verified V +2 Done
- Andreas Kienast +2
- Benjamin Franzke +1
- Garvin Hicking +1
- core-ci +1 CI
Issues 1
Files 21
- Build/Sources/TypeScript/install/module/environment/environment-check.ts+3 −1
- Build/Sources/TypeScript/install/module/environment/folder-structure.ts+3 −2
- Build/Sources/TypeScript/install/module/environment/image-processing.ts+1 −5
- Build/Sources/TypeScript/install/module/maintenance/clear-tables.ts+3 −1
- Build/Sources/TypeScript/install/module/maintenance/clear-typo3temp-files.ts+3 −1
- Build/Sources/TypeScript/install/module/maintenance/database-analyzer.ts+9 −3
- Build/Sources/TypeScript/install/module/upgrade/extension-compat-tester.ts+9 −5
- Build/Sources/TypeScript/install/module/upgrade/extension-scanner.ts8+165 −164
- Build/Sources/TypeScript/install/module/upgrade/tca-ext-tables-check.ts+3 −1
- Build/Sources/TypeScript/install/module/upgrade/tca-migrations-check.ts+3 −2
- typo3/sysext/core/Tests/Acceptance/Application/InstallTool/UpgradeCest.php+0 −2
- typo3/sysext/install/Resources/Public/JavaScript/module/environment/environment-check.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/module/environment/folder-structure.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/module/environment/image-processing.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/module/maintenance/clear-tables.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/module/maintenance/clear-typo3temp-files.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/module/maintenance/database-analyzer.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/module/upgrade/extension-compat-tester.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/module/upgrade/extension-scanner.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/module/upgrade/tca-ext-tables-check.js+1 −1
Review log 2634
Show 69 earlier messages
-
Andreas Kienast uploaded patch set 1 02/06/24, 10:47
-
core-ci voted on patch set 1 V -1 02/06/24, 10:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52767
-
Andreas Kienast uploaded patch set 2
V -102/06/24, 11:11 -
core-ci voted on patch set 2 V -1 02/06/24, 11:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52771
-
Andreas Kienast uploaded patch set 3
V -102/06/24, 11:25 -
core-ci voted on patch set 3 V +1 02/06/24, 11:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52773
-
Garvin Hicking commented on patch set 3 02/06/24, 12:21
Great work on this, thanks so much for adressing it! I tested the following places. I always opened the modal, then made the `config/system/additiona.php` to contain a PHP parse error, plus flushed the cache. Then tried to execute the action button(s) in the modal and verified that a returned error was a) shown and b) allowed me to re-execute the button after that. This is where it worked well, and showed an error message properly: * Admin-Tools > Environment > Check Environment... * Admin-Tools > Environment > Send test mail... * Admin-Tools > Settings > Change Install Tool Password... * Admin-Tools > Settings > Manage System Maintainers... * Admin-Tools > Settings > Choose Preset... * Admin-Tools > Settings > Configure Features... * Admin-Tools > Settings > Configure options... * Admin-Tools > Maintenance > Scan temporary files... * Admin-Tools > Maintenance > Scan tables... * Admin-Tools > Maintenance > Create Administrator... * Admin-Tools > Upgrade > Run Upgrade Wizard This is where it worked, however no error was shown (outside the scope of this PR?, just to note this): * Admin-Tools > Environment > Test Images... * Admin-Tools > Upgrade > Check TCA Migrations... This is where it doesn't yet work (not covered by this PR?): * Admin-Tools > Environment > Check Directory Status... * Admin-Tools > Maintenance > Analyze database ... (buttons don't get re-enabled) * Admin-Tools > Upgrade > Check TCA... (button doesn't get re-enabled) * Admin-Tools > Upgrade > Check Extension Compatibility... (button doesn't get re-enabled) * Admin-Tools > Upgrade > Scan Extension Files... (button doesn't get re-enabled, two error popups get shown instead of one) -
Andreas Kienast commented on patch set 3 V -1 02/06/24, 13:13
Reply
Thank you for your tests > Admin-Tools > Environment > Check Directory Status... This only has a "fix me" button, no re-check button > Admin-Tools > Maintenance > Analyze database > Admin-Tools > Upgrade > Check Extension Compatibility > Admin-Tools > Upgrade > Scan Extension Files Cannot reproduce. Which Install Tool mode did you test in which browser? Also, did you make sure you've cleared your caches? > Admin-Tools > Upgrade > Check TCA Confirmed -
Andreas Kienast uploaded patch set 4
V +102/06/24, 13:14
-
core-ci voted on patch set 4 V +1 02/06/24, 13:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52780
-
Garvin Hicking commented on patch set 4 02/06/24, 16:15
Reply
About the "fix me" Button: Yes, if I click the button (while the "parse error" is active) the button permanently stays disabled. So once I fix the parse error I cannot hit the button again without reloading the backend too. About the three non-reproducible issues for you, I'll try to show you tomorrow (see slack). Used Chromium macOS. -
Andreas Kienast commented on patch set 4 CR -1 02/07/24, 07:43
on it -
Andreas Kienast uploaded patch set 5
CR -1V +102/07/24, 08:43 -
Andreas Kienast commented on patch set 5 02/07/24, 08:45
Reply
Done -
core-ci voted on patch set 5 V +1 02/07/24, 08:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52832
-
Garvin Hicking commented on patch set 5 02/07/24, 09:11
Reply
Oh yes, this is awesome. Thanks for addressing it!! Works now: * Admin-Tools > Upgrade > Check TCA Migrations... * Admin-Tools > Environment > Check Directory Status... * Admin-Tools > Maintenance > Analyze database ... * Admin-Tools > Upgrade > Scan Extension Files... (Tested this mainly in the embedded section of the normal backend, only superficially tested this in the "standalone" /typo3/installer.php, but I'm "feeling lucky" that it should all work the same there) One single thing remains for me: "Admin-Tools > Upgrade > Check Extension Compatibility... " The button now gets re-enabled, but re-clicking it doesn't re-execute the task even when the additional.php error is fixed). In all other modules re-executing the button leads to the functionality getting available again. -
Andreas Kienast uploaded patch set 6
V +102/07/24, 09:27 -
Andreas Kienast commented on patch set 6 02/07/24, 09:27
Reply
Done -
core-ci voted on patch set 6 V +1 02/07/24, 09:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52837
-
Garvin Hicking commented on patch set 6 CR +1 V +1 02/07/24, 09:35
Flawless victory. 👌🏻 -
Benjamin Franzke commented on patch set 6 02/07/24, 09:45
extension-scanner.ts:213Hm, would like to avoid `any`. maybe use `Promise<void>` and later only call `resolve()`? (Or make it `boolean`…) -
Andreas Kienast commented on patch set 6 02/07/24, 10:22
extension-scanner.ts:213ReplyI also return strings in the promises, but I agree it's not pretty. -
Benjamin Franzke commented on patch set 6 02/07/24, 10:26
extension-scanner.ts:213Replybut you pass strings only to reject() - typescript doesn't care about that for the promise type 😄 -
Andreas Kienast uploaded patch set 7
CR +1V +102/07/24, 10:27 -
core-ci voted on patch set 7 V +1 02/07/24, 10:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52844
-
Benjamin Franzke commented on patch set 7 CR -1 02/07/24, 11:54
on itextension-scanner.ts:213ReplyDoneextension-scanner.ts:356I think this needs to be ``` if (doneFiles === numberOfFiles) { resolve(); ``` Otherwise the first failing file would reenable the button before others are finished. Ideally the AjaxQueue would be wrapped in separates promises which're then `Promise.allSettled` as well. Will work on that. -
Andreas Kienast commented on patch set 7 02/07/24, 12:02
extension-scanner.ts:356ReplyThanks! I wonder whether it makes sense to extract this little refactoring into a pre-patch. -
Benjamin Franzke uploaded patch set 8
CR -1V +102/07/24, 12:05 -
Benjamin Franzke commented on patch set 8 02/07/24, 12:07
extension-scanner.ts:356ReplyPushed now, not sure regarding pre-patch or not. Fine with me to include this here. -
core-ci voted on patch set 8 V +1 02/07/24, 12:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52853
-
Benni Mack commented on patch set 8 02/08/24, 22:14
extension-scanner.ts:115Unresolvedlove that one! -
Garvin Hicking voted on patch set 8 CR +1 V +1 02/09/24, 08:30
-
Andreas Kienast voted on patch set 8 CR +2 V +2 02/09/24, 09:21
-
Andreas Kienast merged patch set 9 02/09/24, 09:21