Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.
82816[WIP][BUGFIX] Merge ViewHelper and LinkResult
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 2
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/16/82816/2 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/16/82816/2 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V -1 Blocked
- core-ci -1 CI
Issues 1
Files 5
- typo3/sysext/fluid/Classes/ViewHelpers/Link/PageViewHelper.php+1 −0
- typo3/sysext/fluid/Tests/Functional/Fixtures/pages.csv+10 −9
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Link/ExternalViewHelperTest.php+8 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Link/PageViewHelperTest.php+8 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Link/TypolinkViewHelperTest.php+8 −0
Review log 57
-
Daniel Siepmann uploaded patch set 1 02/06/24, 10:53
-
Daniel Siepmann commented on patch set 1 02/06/24, 10:55
This is WIP for the following reasons: 1. The external ViewHelper does not yet use TYPO3 API and therefore won't trigger Events or add the security related attributes. Should we adopt the ViewHelper to do so in order to streamline? 2. Missing mailto ViewHelper as there is no native way of testing, we would need to provide an EventListener for proper testing? -
core-ci voted on patch set 1 V -1 02/06/24, 10:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52768
-
Daniel Siepmann marked it work in progress 04/24/24, 06:36
-
Benni Mack updated the commit message in patch set 2
V -110/18/24, 13:30 -
core-ci voted on patch set 2 V -1 10/18/24, 19:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67974
-
Benni Mack commented on patch set 2 03/26/25, 11:25
Reply Unresolved
Hey, I think there are three issues for it. So we should use LinkFactory everywhere (separate issue + separate patch), do you agree?