Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.

Review main Work in progress Orphaned

82816[WIP][BUGFIX] Merge ViewHelper and LinkResult

Daniel Siepmann CR 0 V -1 Easy +35 −9 updated 03/26/25, 11:25

Commit message

TYPO3 ships with ViewHelper that allow to build links.
Those ViewHelpers allow to provide some attributes for the final link,
e.g. "class" or "rel".
Those attributes might also be set via TYPO3 internals, e.g.
"noreferrer" for rel as well as by extensions via Events.

Those were not properly handled by those ViewHelper as they only kept
their own attributes.

This now got fixed by providing the ViewHelper context to link
generation which now has the full context and can properly adjust.
The ViewHelpers already used the final outcome of the link building.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 2
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/16/82816/2 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/16/82816/2 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V -1 Blocked
    • core-ci -1 CI

Issues 1

Files 5

Review log 57

  1. Daniel Siepmann uploaded patch set 1 02/06/24, 10:53

  2. Daniel Siepmann commented on patch set 1 02/06/24, 10:55

    This is WIP for the following reasons: 1. The external ViewHelper does not yet use TYPO3 API and therefore won't trigger Events or add the security related attributes. Should we adopt the ViewHelper to do so in order to streamline? 2. Missing mailto ViewHelper as there is no native way of testing, we would need to provide an EventListener for proper testing?
  3. core-ci voted on patch set 1 V -1 02/06/24, 10:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52768

  4. Daniel Siepmann marked it work in progress 04/24/24, 06:36

  5. Benni Mack updated the commit message in patch set 2 V -1 10/18/24, 13:30

  6. core-ci voted on patch set 2 V -1 10/18/24, 19:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67974

  7. Benni Mack commented on patch set 2 03/26/25, 11:25

    Reply Unresolved

    Hey, I think there are three issues for it. So we should use LinkFactory everywhere (separate issue + separate patch), do you agree?