82817[BUGFIX] Handle record export and download options individually
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Jochen Roth +1
- Christian Kuhn +1
-
Verified V +2 Done
- Oli Bartsch +2
- Jochen Roth +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 4
- Build/phpstan/phpstan-baseline.neon+0 −5
- typo3/sysext/backend/Classes/Controller/RecordListController.php+3 −3
- typo3/sysext/backend/Classes/RecordList/DatabaseRecordList.php+16 −5
- typo3/sysext/core/Documentation/Changelog/12.4.x/Important-99781-ExportingAndDownloadingRecordsInTheListModule.rstnew+49 −0
Review log 1013
-
Oli Bartsch uploaded patch set 1 02/06/24, 11:09
-
core-ci voted on patch set 1 V -1 02/06/24, 11:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52770
-
Oli Bartsch uploaded patch set 2
V -102/06/24, 13:02 -
core-ci voted on patch set 2 V +1 02/06/24, 13:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52779
-
Oli Bartsch uploaded patch set 3
V +102/09/24, 08:59 -
core-ci voted on patch set 3 V +1 02/09/24, 09:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52941
-
Jochen Roth voted on patch set 3 CR +1 V +1 02/09/24, 11:22
-
Christian Kuhn commented on patch set 3 02/09/24, 12:18
imho not important enough for v12. just get it done for v13 and that's it, then rename to feature. codewise fine. will upvote. -
Oli Bartsch commented on patch set 3 02/09/24, 13:08
Reply
We could argue whether this should go to v12, but it's IMO no feature as the TSconfig option was misused by the download component. -
Christian Kuhn voted on patch set 3 CR +1 V +1 02/09/24, 13:13
-
Christian Kuhn commented on patch set 3 02/09/24, 13:14
Reply
ack -
Oli Bartsch voted on patch set 3 CR +2 V +2 02/09/24, 17:34
-
Oli Bartsch merged patch set 4 02/09/24, 17:34