82826[BUGFIX] Fix list view functionality in FileList
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Jochen Roth +1
- Stefan Bürk +1
-
Verified V +2 Done
- Oli Bartsch +2
- Jochen Roth +1
- Sybille Peters +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1417
-
Oli Bartsch uploaded patch set 1 02/06/24, 16:13
-
core-ci voted on patch set 1 V +1 02/06/24, 16:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52801
-
Daniel Siepmann commented on patch set 1 02/08/24, 09:52
I tested this, and it doesn't solve the pagination issue (if no sorting is applied) mentioned within the issue, at least not in v12.4. -
Jochen Roth commented on patch set 1 V -1 02/09/24, 11:42
The size sorting seems to work only if a search term is given. -
Jochen Roth commented on patch set 1 CR +1 V +1 02/09/24, 13:03
Reply
Sorry, my bad. Should have checked properly. -
Sybille Peters commented on patch set 1 V -1 02/09/24, 13:52
(1) Something is weird now: The search term changed when I paginated (approximately, something like this, might be slightly different because I tested several things) 1. search for "jpg" 2. change sort order (by size) : result: ok 3. search for "png" 4. paginate to next page : search term (in input field) is "jpg" again (2) Also, I think when a new search term is used or the sort order changes, it should always start on the first page (meaning the pagination should be reset). IMHO, resuming on a different page does not make sense. Try 1. no search term 2. paginate to second page 3. change search term (e.g. "png") : will resume on second page -
Sybille Peters commented on patch set 1 02/09/24, 13:57
Reply
Settings this to resolved. Please comment again, if not correct. -
Oli Bartsch uploaded patch set 2
CR +1V +102/09/24, 17:09 -
Oli Bartsch commented on patch set 2 02/09/24, 17:11
Reply
Thanks for testing and the feedback. While those bugs were not related to the patch (meaning they existed independently), I have updated the patch to also tackle them. -
core-ci voted on patch set 2 V +1 02/09/24, 17:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52973
-
Sybille Peters updated the commit message in patch set 3
V +102/09/24, 17:27 -
core-ci voted on patch set 3 V +1 02/09/24, 17:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52976
-
Sybille Peters voted on patch set 3 V +1 02/10/24, 14:49
-
Jochen Roth voted on patch set 3 CR +1 V +1 02/11/24, 09:37
-
Stefan Bürk voted on patch set 3 CR +1 V +1 02/12/24, 11:42
-
Oli Bartsch voted on patch set 3 CR +2 V +2 02/12/24, 15:32
-
Oli Bartsch merged patch set 4 02/12/24, 15:32