Review main Merged

82826[BUGFIX] Fix list view functionality in FileList

Oli Bartsch CR +2 V +2 Easy +8 −1 updated 02/12/24, 15:32

Commit message

This fixes several bugs in FileList:

1. Properly initializing the `searchTerm` ensures
   it is kept while sorting.
2. Sorting for "filesize" is now working properly,
   using corresponding collator attribute.
3. Pagination is properly reset on searching.
4. Correct search term is kept on paginating.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Sybille Peters +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1417

  1. Oli Bartsch uploaded patch set 1 02/06/24, 16:13

  2. core-ci voted on patch set 1 V +1 02/06/24, 16:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52801

  3. Daniel Siepmann commented on patch set 1 02/08/24, 09:52

    I tested this, and it doesn't solve the pagination issue (if no sorting is applied) mentioned within the issue, at least not in v12.4.
  4. Jochen Roth commented on patch set 1 V -1 02/09/24, 11:42

    The size sorting seems to work only if a search term is given.
  5. Jochen Roth commented on patch set 1 CR +1 V +1 02/09/24, 13:03

    Reply

    Sorry, my bad. Should have checked properly.
  6. Sybille Peters commented on patch set 1 V -1 02/09/24, 13:52

    (1) Something is weird now: The search term changed when I paginated (approximately, something like this, might be slightly different because I tested several things) 1. search for "jpg" 2. change sort order (by size) : result: ok 3. search for "png" 4. paginate to next page : search term (in input field) is "jpg" again (2) Also, I think when a new search term is used or the sort order changes, it should always start on the first page (meaning the pagination should be reset). IMHO, resuming on a different page does not make sense. Try 1. no search term 2. paginate to second page 3. change search term (e.g. "png") : will resume on second page
  7. Sybille Peters commented on patch set 1 02/09/24, 13:57

    Reply

    Settings this to resolved. Please comment again, if not correct.
  8. Oli Bartsch uploaded patch set 2 CR +1 V +1 02/09/24, 17:09

  9. Oli Bartsch commented on patch set 2 02/09/24, 17:11

    Reply

    Thanks for testing and the feedback. While those bugs were not related to the patch (meaning they existed independently), I have updated the patch to also tackle them.
  10. core-ci voted on patch set 2 V +1 02/09/24, 17:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52973

  11. Sybille Peters updated the commit message in patch set 3 V +1 02/09/24, 17:27

  12. core-ci voted on patch set 3 V +1 02/09/24, 17:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52976

  13. Sybille Peters voted on patch set 3 V +1 02/10/24, 14:49

  14. Jochen Roth voted on patch set 3 CR +1 V +1 02/11/24, 09:37

  15. Stefan Bürk voted on patch set 3 CR +1 V +1 02/12/24, 11:42

  16. Oli Bartsch voted on patch set 3 CR +2 V +2 02/12/24, 15:32

  17. Oli Bartsch merged patch set 4 02/12/24, 15:32