82830[BUGFIX] Avoid autocompletion in TCA type password
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Oliver Klee +1
- Andreas Kienast +1
- Benni Mack +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Benni Mack +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 2
Files 2
Review log 1012
-
Benjamin Franzke uploaded patch set 1 02/07/24, 09:20
-
core-ci voted on patch set 1 V +1 02/07/24, 09:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52834
-
Andreas Kienast updated the commit message in patch set 2
V +102/07/24, 10:44 -
Andreas Kienast voted on patch set 2 CR +1 02/07/24, 10:48
-
core-ci voted on patch set 2 V +1 02/07/24, 10:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52847
-
Simon Schaufelberger commented on patch set 2 CR +1 V +1 02/07/24, 11:08
felogin is already correct. -
Oliver Klee voted on patch set 2 CR +1 02/07/24, 16:29
-
Benni Mack commented on patch set 2 02/09/24, 07:22
PasswordElement.php:127I think "current password" isn't the best option tbh, imagine, I would modify an existing FE User or another (!= myself) BE User... that would suggest _my_ current password. WDYT? -
Benjamin Franzke commented on patch set 2 02/09/24, 07:45
PasswordElement.php:127ReplyRight, that's why `autocomplete` is not enabled by default. But if `autocomplete` is defined for a TCA type password, then yes, the browser should do autocompletion then. I don't know the reasons why this config was added at all (maybe in case type=password will be used for user-self-setup at some point), but I'm quite sure `current-password` is fine here. -
Benni Mack commented on patch set 2 CR +1 V +1 02/13/24, 07:40
PasswordElement.php:127ReplyDone -
Benjamin Franzke voted on patch set 2 CR +2 V +2 02/13/24, 07:40
-
Benjamin Franzke merged patch set 3 02/13/24, 07:40