Review main Merged

82830[BUGFIX] Avoid autocompletion in TCA type password

Benjamin Franzke CR +2 V +2 Easy +3 −3 updated 02/13/24, 07:40

Commit message

The autocomplete="off" parameter is ignored by current browsers,
autocomplete="new-password" is to be used for disable autocompletion.

The explicit request for autocompleting the password is
autocomplete="current-password", which is now used in case config TCA
autocomplete is set.

See following article for more information:
 * https://web.dev/articles/sign-in-form-best-practices#new-password
 * https://web.dev/articles/sign-in-form-best-practices#current-password

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oliver Klee +1
    • Andreas Kienast +1
    • Benni Mack +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Benni Mack +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 1012

  1. Benjamin Franzke uploaded patch set 1 02/07/24, 09:20

  2. core-ci voted on patch set 1 V +1 02/07/24, 09:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52834

  3. Andreas Kienast updated the commit message in patch set 2 V +1 02/07/24, 10:44

  4. Andreas Kienast voted on patch set 2 CR +1 02/07/24, 10:48

  5. core-ci voted on patch set 2 V +1 02/07/24, 10:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52847

  6. Simon Schaufelberger commented on patch set 2 CR +1 V +1 02/07/24, 11:08

    felogin is already correct.
  7. Oliver Klee voted on patch set 2 CR +1 02/07/24, 16:29

  8. Benni Mack commented on patch set 2 02/09/24, 07:22

    PasswordElement.php:127

    I think "current password" isn't the best option tbh, imagine, I would modify an existing FE User or another (!= myself) BE User... that would suggest _my_ current password. WDYT?
  9. Benjamin Franzke commented on patch set 2 02/09/24, 07:45

    PasswordElement.php:127 Reply

    Right, that's why `autocomplete` is not enabled by default. But if `autocomplete` is defined for a TCA type password, then yes, the browser should do autocompletion then. I don't know the reasons why this config was added at all (maybe in case type=password will be used for user-self-setup at some point), but I'm quite sure `current-password` is fine here.
  10. Benni Mack commented on patch set 2 CR +1 V +1 02/13/24, 07:40

    PasswordElement.php:127 Reply

    Done
  11. Benjamin Franzke voted on patch set 2 CR +2 V +2 02/13/24, 07:40

  12. Benjamin Franzke merged patch set 3 02/13/24, 07:40