Review 13.0 Merged

82841[TASK] Replace former extension packages using self.version

Benjamin Franzke CR +2 V +2 Easy +13 −13 updated 02/09/24, 11:29

Commit message

The so called "death star" range for replacements has to be
used with caution [1] as it replaces all versions of the
replaced packages, including old or insecure versions.

That effectively means the replacing package marks itself as matching
in queries for insecure versions, once a security advisory[2]
is submitted for the replaced packages.

The extension replacements are now adapted to use the more precise
self.version qualifier to avoid matching named security advisories as
suggested by:
https://github.com/Roave/SecurityAdvisories/issues/127#issuecomment-1933647035

[1] https://getcomposer.org/doc/04-schema.md#replace
[2] https://github.com/advisories/GHSA-cgr9-h9qq-x9fx

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 1

Files 4

Review log 34

  1. Benjamin Franzke commented on patch set 1 02/09/24, 11:16

    Cherry Picked from branch main.
  2. Benjamin Franzke voted on patch set 1 CR +2 V +2 02/09/24, 11:19

  3. core-ci voted on patch set 1 V +1 02/09/24, 11:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52951

  4. Benjamin Franzke merged patch set 2 02/09/24, 11:29