Review main Merged

82860[TASK] Fix acceptence tests window size with php-webdriver 1.15

Benjamin Kott CR +2 V +2 Easy +12 −8 updated 02/08/24, 13:17

Commit message

The configured browser capabilities (`chromeOptions`) are passed by
`codeception/module-webdriver` to `php-webdriver` as is.
php-webdriver expects the PHP constant ChromeOptions::CAPABILITY to be
used instead of hardcoding any strings. Therefore php-webdriver 1.15
changed this constants value from `chromeOptions` to
`goog:chromeOptions` [1], which means that the option `chromeOptions`
is no longer respected and the configured window size (and the headless
flag) is ignored.

We now use the newer W3C webdriver comaptible `goog:chromeOptions`
option and define window size definition via codeception's respective
option `window_size` while we are at it.

[1] https://github.com/php-webdriver/php-webdriver/commit/235c2aa07

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Benjamin Franzke +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Benjamin Franzke +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 917

  1. Benjamin Kott uploaded patch set 1 02/08/24, 08:58

  2. core-ci voted on patch set 1 V +1 02/08/24, 09:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52879

  3. core-ci voted on patch set 1 V -1 02/08/24, 09:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52880

  4. Benjamin Kott uploaded patch set 2 V -1 02/08/24, 09:41

  5. Benjamin Kott uploaded patch set 3 02/08/24, 09:54

  6. core-ci voted on patch set 3 V +1 02/08/24, 10:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52885

  7. Benjamin Kott uploaded patch set 4 V +1 02/08/24, 10:11

  8. core-ci voted on patch set 4 V +1 02/08/24, 10:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52886

  9. core-ci commented on patch set 4 02/08/24, 10:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52887

  10. Benjamin Franzke uploaded patch set 5 V +1 02/08/24, 11:01

  11. Benjamin Franzke updated the commit message in patch set 6 CR +1 V +1 02/08/24, 11:04

  12. Stefan Bürk commented on patch set 6 CR -1 02/08/24, 11:08

    temp -1, will run nightly first
  13. core-ci voted on patch set 5 V +1 02/08/24, 11:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52888

  14. core-ci voted on patch set 6 V +1 02/08/24, 11:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52890

  15. core-ci commented on patch set 6 02/08/24, 11:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52896

  16. Stefan Bürk voted on patch set 6 CR +2 V +2 02/08/24, 13:17

  17. Stefan Bürk merged patch set 7 02/08/24, 13:17