Review main Merged

82865[TASK] Set `argon2id` as default password hashing algorithm

Andreas Kienast CR +2 V +2 Easy +12 −12 updated 02/09/24, 12:01

Commit message

`argon2id` is available since PHP 7.3. Since this version requirement
is fulfilled for quite some time already, it's time to set the hashing
algorithm as the default one.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • Oliver Klee +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1014

  1. Andreas Kienast uploaded patch set 1 02/08/24, 13:35

  2. core-ci voted on patch set 1 V -1 02/08/24, 13:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52911

  3. Andreas Kienast uploaded patch set 2 V -1 02/08/24, 13:48

  4. Andreas Kienast uploaded patch set 3 02/08/24, 13:53

  5. Andreas Kienast uploaded patch set 4 02/08/24, 13:54

  6. core-ci voted on patch set 2 V -1 02/08/24, 13:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52912

  7. core-ci voted on patch set 4 V +1 02/08/24, 14:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52914

  8. core-ci voted on patch set 3 V +1 02/08/24, 14:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52913

  9. Oliver Klee voted on patch set 4 CR +1 02/08/24, 14:01

  10. Christian Kuhn commented on patch set 4 CR +1 V +1 02/09/24, 11:31

    PasswordHashFactoryTest.php:226

    haha. nice.
  11. Christian Kuhn commented on patch set 4 02/09/24, 11:32

    PasswordHashFactoryTest.php:226 Reply

    Done
  12. Oli Bartsch voted on patch set 4 CR +1 V +1 02/09/24, 11:35

  13. Andreas Kienast voted on patch set 4 CR +2 V +2 02/09/24, 12:01

  14. Andreas Kienast merged patch set 5 02/09/24, 12:01