82866[TASK] Allow execution of acceptance tests with local chromedriver
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Stefan Bürk +1
- Benni Mack +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Stefan Bürk +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 7
- Build/Scripts/runTests.sh+10 −10
- typo3/sysext/core/Tests/Acceptance/Fixtures/BackendEnvironment.csv+0 −5
- typo3/sysext/core/Tests/Acceptance/Helper/PasswordLogin.php2new+91 −0
- typo3/sysext/core/Tests/Acceptance/Application.suite.yml2+9 −30
- typo3/sysext/core/Tests/Acceptance/Install.suite.yml+0 −26
- typo3/sysext/core/Tests/codeception.yml+25 −0
- typo3/sysext/core/Tests/parameters.yml+3 −2
Review log 1829
Show 24 earlier messages
-
Benjamin Franzke uploaded patch set 1 02/08/24, 21:46
-
core-ci voted on patch set 1 V -1 02/08/24, 21:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52925
-
Benjamin Franzke uploaded patch set 2
V -102/08/24, 22:00 -
core-ci voted on patch set 2 V -1 02/08/24, 22:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52926
-
Benjamin Franzke uploaded patch set 3
V -102/08/24, 22:15 -
core-ci voted on patch set 3 V -1 02/08/24, 22:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52927
-
Benjamin Franzke uploaded patch set 4
V -102/08/24, 22:49 -
core-ci voted on patch set 4 V -1 02/08/24, 22:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52928
-
Benjamin Franzke uploaded patch set 5
V -102/08/24, 22:56 -
core-ci voted on patch set 5 V +1 02/08/24, 23:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52929
-
Benjamin Franzke uploaded patch set 6
V +102/08/24, 23:31 -
core-ci voted on patch set 6 V +1 02/08/24, 23:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52930
-
Benjamin Franzke uploaded patch set 7
V +102/09/24, 06:05 -
core-ci voted on patch set 7 V +1 02/09/24, 06:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52934
-
Benjamin Franzke rebased onto patch set 8
V +102/18/24, 20:38Rebase -
core-ci voted on patch set 8 V +1 02/18/24, 20:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53314
-
Benjamin Franzke commented on patch set 8 CR -1 02/19/24, 14:13
Application.suite.yml:16%typo3TestingAcceptanceEditorPassword%PasswordLogin.php:31unused -
Benjamin Franzke uploaded patch set 9
CR -1V +102/19/24, 16:29 -
Benjamin Franzke commented on patch set 9 02/19/24, 16:29
Application.suite.yml:16ReplyDonePasswordLogin.php:31ReplyDone -
core-ci voted on patch set 9 V +1 02/19/24, 16:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53345
-
core-ci commented on patch set 9 02/20/24, 11:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53368
-
Frank Nägler rebased onto patch set 10
V +103/04/24, 07:49 -
core-ci voted on patch set 10 V +1 03/04/24, 07:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53806
-
Benjamin Franzke wrote 03/04/24, 07:55
Unset private -
Stefan Bürk commented on patch set 10 CR +1 V +1 03/04/24, 13:58
TBH not sure about eventually conflicts when local instance data diverges as not really ensured. Maybe I'm just not getting it how this should/would be ensured later on. However, from my side okay to allow it atm - as I guess this will be used of only a one hand full of people from the inner core development cycle. -
Benjamin Franzke commented on patch set 10 03/04/24, 18:37
Reply
Ack, for 100% valid runs a fresh-setup is needed, but this helps for running non-mutating tests on an existing instance. -
Benni Mack voted on patch set 10 CR +1 V +1 03/05/24, 11:49
-
Benjamin Franzke voted on patch set 10 CR +2 V +2 03/05/24, 11:49
-
Benjamin Franzke merged patch set 11 03/05/24, 11:50