Review main Merged

82866[TASK] Allow execution of acceptance tests with local chromedriver

Benjamin Franzke CR +2 V +2 Normal +138 −73 updated 03/05/24, 11:50

Commit message

A local instance can sometimes be easier to debug and browser issues
can be introspected, when acceptance tests are possible to be run on
the host instead of in containers only.

Allow to run acceptance tests against a local server using a local
chromedriver. Also avoid the usage of precalculated session hashes,
which has no clear advantage, but requires codecept to perform
database connections directly: The tests now login via the backend
login form instead and store the session cookies between test runs.

As a side effect the codeception suites are cleaned up, to use
more efficient module config, instead of redundantly repeating
all WebDriver settings for headless and non-headless environment.

To execute codeception with local chromedriver against a custom
server URL run:

  chromedriver --silent & # use `killall chromedriver` when done

  typo3TestingAcceptanceBaseUrl=https://mycore.example.com/ \
  typo3TestingAcceptanceAdminPassword="MyAdminPa$$w0rd" \
  typo3TestingAcceptanceEditorPassword="MyEditorPa$$w0rd" \
  bin/codecept -c typo3/sysext/core/Tests/codeception.yml -d \
    run Application

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 1829

Show 24 earlier messages
  1. Benjamin Franzke uploaded patch set 1 02/08/24, 21:46

  2. core-ci voted on patch set 1 V -1 02/08/24, 21:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52925

  3. Benjamin Franzke uploaded patch set 2 V -1 02/08/24, 22:00

  4. core-ci voted on patch set 2 V -1 02/08/24, 22:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52926

  1. Benjamin Franzke uploaded patch set 3 V -1 02/08/24, 22:15

  2. core-ci voted on patch set 3 V -1 02/08/24, 22:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52927

  3. Benjamin Franzke uploaded patch set 4 V -1 02/08/24, 22:49

  4. core-ci voted on patch set 4 V -1 02/08/24, 22:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52928

  5. Benjamin Franzke uploaded patch set 5 V -1 02/08/24, 22:56

  6. core-ci voted on patch set 5 V +1 02/08/24, 23:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52929

  7. Benjamin Franzke uploaded patch set 6 V +1 02/08/24, 23:31

  8. core-ci voted on patch set 6 V +1 02/08/24, 23:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52930

  9. Benjamin Franzke uploaded patch set 7 V +1 02/09/24, 06:05

  10. core-ci voted on patch set 7 V +1 02/09/24, 06:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52934

  11. Benjamin Franzke rebased onto patch set 8 V +1 02/18/24, 20:38

    Rebase
  12. core-ci voted on patch set 8 V +1 02/18/24, 20:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53314

  13. Benjamin Franzke commented on patch set 8 CR -1 02/19/24, 14:13

    Application.suite.yml:16

    %typo3TestingAcceptanceEditorPassword%

    PasswordLogin.php:31

    unused
  14. Benjamin Franzke uploaded patch set 9 CR -1 V +1 02/19/24, 16:29

  15. Benjamin Franzke commented on patch set 9 02/19/24, 16:29

    Application.suite.yml:16 Reply

    Done

    PasswordLogin.php:31 Reply

    Done
  16. core-ci voted on patch set 9 V +1 02/19/24, 16:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53345

  17. core-ci commented on patch set 9 02/20/24, 11:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53368

  18. Frank Nägler rebased onto patch set 10 V +1 03/04/24, 07:49

  19. core-ci voted on patch set 10 V +1 03/04/24, 07:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53806

  20. Benjamin Franzke wrote 03/04/24, 07:55

    Unset private
  21. Stefan Bürk commented on patch set 10 CR +1 V +1 03/04/24, 13:58

    TBH not sure about eventually conflicts when local instance data diverges as not really ensured. Maybe I'm just not getting it how this should/would be ensured later on. However, from my side okay to allow it atm - as I guess this will be used of only a one hand full of people from the inner core development cycle.
  22. Benjamin Franzke commented on patch set 10 03/04/24, 18:37

    Reply

    Ack, for 100% valid runs a fresh-setup is needed, but this helps for running non-mutating tests on an existing instance.
  23. Benni Mack voted on patch set 10 CR +1 V +1 03/05/24, 11:49

  24. Benjamin Franzke voted on patch set 10 CR +2 V +2 03/05/24, 11:49

  25. Benjamin Franzke merged patch set 11 03/05/24, 11:50