Review main Merged

82876[FEATURE] Allow custom linktype labels in EXT:linkvalidator

Sybille Peters CR +2 V +2 Normal +188 −4 updated 09/13/24, 21:12

Commit message

If a custom linktype is registered for the Linkvalidator, it is now
possible to define the label which will be displayed in the
backend module.

A new interface `LabelledLinktypeInterface` provides a method
`getReadableName()` to return the custom label. It is implemented
by default in the `AbstractLinktype` class, so any custom
linktype extending from this will be able to override the method.

When no abstract class is extended, compositing a class
with the `LabelledLinktypeInterface` implementation is possible.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 11

Review log 4057

Show 2232 earlier messages
  1. Sybille Peters uploaded patch set 1 02/09/24, 11:49

  2. Sybille Peters updated the commit message in patch set 2 02/09/24, 11:50

  3. Sybille Peters uploaded patch set 3 02/09/24, 11:55

  4. Sybille Peters wrote 02/09/24, 11:55

    Topic set to Linkvalidator
  5. core-ci voted on patch set 1 V -1 02/09/24, 11:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52955

  6. core-ci voted on patch set 2 V -1 02/09/24, 12:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52956

  7. core-ci voted on patch set 3 V -1 02/09/24, 12:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52958

  8. Sybille Peters uploaded patch set 4 V -1 02/09/24, 12:16

  9. core-ci voted on patch set 4 V +1 02/09/24, 12:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52959

  10. Chris Müller commented on patch set 4 CR -1 02/11/24, 08:52

    LinktypeInterface.php:84

    I assume this as breaking as it introduces a new method to a public interface and should therefore go to a ".0" release. To mitigate this and to get this into the current v13 cycle, you can comment this method out, so it is not mandatory (and add it to v14 as mandatory). In your code you then have to check, if the method exists (and if not fall back to some generic value). We have done that in the past this way with the getOptions() method in the dashboard's WidgetInterface (see also: https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/12.0/Breaking-96222-AddGetOptionsToWidgetInterface.html)
  11. Sybille Peters uploaded patch set 5 CR -1 V +1 02/11/24, 10:45

  12. Sybille Peters commented on patch set 4 02/11/24, 10:45

    LinktypeInterface.php:84 Reply

    Is changed as suggested.
  13. core-ci voted on patch set 5 V +1 02/11/24, 10:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53056

  14. Jörg Bösche voted on patch set 5 CR +1 02/27/24, 08:18

  15. Sybille Peters rebased onto patch set 6 CR +1 V +1 03/03/24, 07:38

  16. core-ci voted on patch set 6 V +1 03/03/24, 07:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53786

  17. Rémy DANIEL commented on patch set 6 03/14/24, 11:25

    Feature-103090-MakeLinktypeLabelConfigurable.rst:16

    Typo: cass -> class
  18. Sybille Peters uploaded patch set 7 V +1 03/15/24, 07:12

  19. Sybille Peters commented on patch set 7 03/15/24, 07:16

    Feature-103090-MakeLinktypeLabelConfigurable.rst:16 Reply

    Thanks Rémy! Is fixed.
  20. core-ci voted on patch set 7 V +1 03/15/24, 07:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54561

  21. Sybille Peters uploaded patch set 8 V +1 03/26/24, 06:30

  22. core-ci voted on patch set 8 V +1 03/26/24, 06:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54945

  23. Sybille Peters uploaded patch set 9 V +1 06/22/24, 05:19

  24. core-ci voted on patch set 9 V +1 06/22/24, 05:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60060

  25. Rémy DANIEL voted on patch set 9 CR +1 06/22/24, 19:01

  26. Torben Hansen commented on patch set 9 CR +1 06/25/24, 16:08

    Deprecation-103090-CustomLinktypeInterfaceClassesShouldNowImplementMethodGetLinktypeReadableName.rst:14

    Here a "used" is missing. ("can now be used...")
  27. Georg Ringer commented on patch set 10 CR +1 V +1 06/25/24, 20:00

    Published edit on patch set 9.
  28. core-ci voted on patch set 10 V +1 06/25/24, 20:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60320

  29. Sybille Peters commented on patch set 10 06/26/24, 03:44

    Deprecation-103090-CustomLinktypeInterfaceClassesShouldNowImplementMethodGetLinktypeReadableName.rst:14 Reply

    Was resolved. Thanks.
  30. Torben Hansen voted on patch set 10 CR +1 V +1 06/26/24, 06:13

  31. Stefan Bürk commented on patch set 10 CR -1 06/26/24, 07:54

    ReST files needs to be moved to 13.2 folder ...
  32. Sybille Peters uploaded patch set 11 CR +1 V +1 06/26/24, 08:26

  1. Sybille Peters commented on patch set 11 06/26/24, 08:27

    Reply

    Done
  2. Sybille Peters uploaded patch set 12 06/26/24, 08:28

  3. Sybille Peters updated the commit message in patch set 13 06/26/24, 08:30

  4. core-ci voted on patch set 11 V +1 06/26/24, 08:32 Copied votes on follow-up patch sets have been updated: * Verified+1 has been copied to patch set 12 (copy condition: "changekind:NO_CHANGE"). Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60358

  5. core-ci voted on patch set 12 V +1 06/26/24, 08:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60359

  6. core-ci voted on patch set 13 V +1 06/26/24, 08:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60360

  7. Torben Hansen voted on patch set 13 CR +1 V +1 06/26/24, 17:28

  8. Georg Ringer voted on patch set 13 CR +1 V +1 06/26/24, 18:02

  9. Stefan Bürk voted on patch set 13 CR -1 06/28/24, 12:56

  10. Stefan Bürk uploaded patch set 14 CR +1 V +1 09/12/24, 02:27

  11. core-ci voted on patch set 14 V +1 09/12/24, 02:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65514

  12. Oliver Hader commented on patch set 14 09/12/24, 08:54

    LinktypeInterface.php:87

    Just a question: Would it be better to introduce a new `LinktypeLabelInterface`, which declared `getReadableName(): string`?
  13. Oliver Hader voted on patch set 14 CR +1 09/12/24, 08:54

  14. Stefan Bürk commented on patch set 14 CR -1 09/12/24, 13:19

    LinktypeInterface.php:87 Reply

    As "additional" composing interface ? good idee, not thought about that. That way, we don't need any deprecation at all.
  15. Garvin Hicking uploaded patch set 15 CR +1 V +1 09/13/24, 16:02

    POC of LabelledLinktypeInterface
  16. core-ci voted on patch set 15 V +1 09/13/24, 16:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65697

  17. Stefan Bürk voted on patch set 15 CR +1 V +1 09/13/24, 20:44

  18. Stefan Bürk commented on patch set 15 09/13/24, 20:45

    LinktypeInterface.php:87 Reply

    Done
  19. Stefan Bürk uploaded patch set 16 CR +1 V +1 09/13/24, 20:46

  20. Stefan Bürk voted on patch set 16 CR +1 V +1 09/13/24, 20:47

  21. Garvin Hicking voted on patch set 16 CR +1 V +1 09/13/24, 20:51

  22. core-ci voted on patch set 16 V -1 09/13/24, 20:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65708

  23. core-ci voted on patch set 16 V +1 09/13/24, 21:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65708

  24. Stefan Bürk voted on patch set 16 CR +2 V +2 09/13/24, 21:12

  25. Stefan Bürk merged patch set 17 09/13/24, 21:12