82876[FEATURE] Allow custom linktype labels in EXT:linkvalidator
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Garvin Hicking +1
-
Verified V +2 Done
- Stefan Bürk +2
- Garvin Hicking +1
- core-ci +1 CI
Issues 1
Files 11
- typo3/sysext/core/Documentation/Changelog/13.3/Feature-103090-MakeLinktypeLabelConfigurable.rstnew+85 −0
- typo3/sysext/linkvalidator/Classes/Controller/LinkValidatorController.php+6 −1
- typo3/sysext/linkvalidator/Classes/Linktype/AbstractLinktype.php+11 −2
- typo3/sysext/linkvalidator/Classes/Linktype/LabelledLinktypeInterface.phpnew+33 −0
- typo3/sysext/linkvalidator/Documentation/CodeSnippets/Api/AbstractLinktype.rst.txt+7 −0
- typo3/sysext/linkvalidator/Documentation/CodeSnippets/Api/LabelledLinktypeInterface.rst.txtnew+17 −0
- typo3/sysext/linkvalidator/Documentation/CodeSnippets/Config/All.php+6 −0
- typo3/sysext/linkvalidator/Documentation/Development/Api/Index.rst+1 −0
- typo3/sysext/linkvalidator/Documentation/Development/Api/LabelledLinktypeInterface.rstnew+9 −0
- typo3/sysext/linkvalidator/Documentation/Development/LinkTypeImplementation.rst+6 −0
- typo3/sysext/linkvalidator/Tests/Unit/Linktype/LinktypeRegistryTest.php+7 −1
Review log 4057
Show 2232 earlier messages
-
Sybille Peters uploaded patch set 1 02/09/24, 11:49
-
Sybille Peters updated the commit message in patch set 2 02/09/24, 11:50
-
Sybille Peters uploaded patch set 3 02/09/24, 11:55
-
Sybille Peters wrote 02/09/24, 11:55
Topic set to Linkvalidator -
core-ci voted on patch set 1 V -1 02/09/24, 11:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52955
-
core-ci voted on patch set 2 V -1 02/09/24, 12:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52956
-
core-ci voted on patch set 3 V -1 02/09/24, 12:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52958
-
Sybille Peters uploaded patch set 4
V -102/09/24, 12:16 -
core-ci voted on patch set 4 V +1 02/09/24, 12:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52959
-
Chris Müller commented on patch set 4 CR -1 02/11/24, 08:52
LinktypeInterface.php:84I assume this as breaking as it introduces a new method to a public interface and should therefore go to a ".0" release. To mitigate this and to get this into the current v13 cycle, you can comment this method out, so it is not mandatory (and add it to v14 as mandatory). In your code you then have to check, if the method exists (and if not fall back to some generic value). We have done that in the past this way with the getOptions() method in the dashboard's WidgetInterface (see also: https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/12.0/Breaking-96222-AddGetOptionsToWidgetInterface.html) -
Sybille Peters uploaded patch set 5
CR -1V +102/11/24, 10:45 -
Sybille Peters commented on patch set 4 02/11/24, 10:45
LinktypeInterface.php:84ReplyIs changed as suggested. -
core-ci voted on patch set 5 V +1 02/11/24, 10:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53056
-
Jörg Bösche voted on patch set 5 CR +1 02/27/24, 08:18
-
Sybille Peters rebased onto patch set 6
CR +1V +103/03/24, 07:38 -
core-ci voted on patch set 6 V +1 03/03/24, 07:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53786
-
Rémy DANIEL commented on patch set 6 03/14/24, 11:25
Feature-103090-MakeLinktypeLabelConfigurable.rst:16Typo: cass -> class -
Sybille Peters uploaded patch set 7
V +103/15/24, 07:12 -
Sybille Peters commented on patch set 7 03/15/24, 07:16
Feature-103090-MakeLinktypeLabelConfigurable.rst:16ReplyThanks Rémy! Is fixed. -
core-ci voted on patch set 7 V +1 03/15/24, 07:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54561
-
Sybille Peters uploaded patch set 8
V +103/26/24, 06:30 -
core-ci voted on patch set 8 V +1 03/26/24, 06:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54945
-
Sybille Peters uploaded patch set 9
V +106/22/24, 05:19 -
core-ci voted on patch set 9 V +1 06/22/24, 05:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60060
-
Rémy DANIEL voted on patch set 9 CR +1 06/22/24, 19:01
-
Torben Hansen commented on patch set 9 CR +1 06/25/24, 16:08
Deprecation-103090-CustomLinktypeInterfaceClassesShouldNowImplementMethodGetLinktypeReadableName.rst:14Here a "used" is missing. ("can now be used...") -
Georg Ringer commented on patch set 10
CR +1V +106/25/24, 20:00Published edit on patch set 9. -
core-ci voted on patch set 10 V +1 06/25/24, 20:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60320
-
Sybille Peters commented on patch set 10 06/26/24, 03:44
Deprecation-103090-CustomLinktypeInterfaceClassesShouldNowImplementMethodGetLinktypeReadableName.rst:14ReplyWas resolved. Thanks. -
Torben Hansen voted on patch set 10 CR +1 V +1 06/26/24, 06:13
-
Stefan Bürk commented on patch set 10 CR -1 06/26/24, 07:54
ReST files needs to be moved to 13.2 folder ... -
Sybille Peters uploaded patch set 11
CR +1V +106/26/24, 08:26
-
Sybille Peters commented on patch set 11 06/26/24, 08:27
Reply
Done -
Sybille Peters uploaded patch set 12 06/26/24, 08:28
-
Sybille Peters updated the commit message in patch set 13 06/26/24, 08:30
-
core-ci voted on patch set 11 V +1 06/26/24, 08:32 Copied votes on follow-up patch sets have been updated: * Verified+1 has been copied to patch set 12 (copy condition: "changekind:NO_CHANGE"). Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60358
-
core-ci voted on patch set 12 V +1 06/26/24, 08:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60359
-
core-ci voted on patch set 13 V +1 06/26/24, 08:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60360
-
Torben Hansen voted on patch set 13 CR +1 V +1 06/26/24, 17:28
-
Georg Ringer voted on patch set 13 CR +1 V +1 06/26/24, 18:02
-
Stefan Bürk voted on patch set 13 CR -1 06/28/24, 12:56
-
Stefan Bürk uploaded patch set 14
CR +1V +109/12/24, 02:27 -
core-ci voted on patch set 14 V +1 09/12/24, 02:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65514
-
Oliver Hader commented on patch set 14 09/12/24, 08:54
LinktypeInterface.php:87Just a question: Would it be better to introduce a new `LinktypeLabelInterface`, which declared `getReadableName(): string`? -
Oliver Hader voted on patch set 14 CR +1 09/12/24, 08:54
-
Stefan Bürk commented on patch set 14 CR -1 09/12/24, 13:19
LinktypeInterface.php:87ReplyAs "additional" composing interface ? good idee, not thought about that. That way, we don't need any deprecation at all. -
Garvin Hicking uploaded patch set 15
CR +1V +109/13/24, 16:02POC of LabelledLinktypeInterface -
core-ci voted on patch set 15 V +1 09/13/24, 16:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65697
-
Stefan Bürk voted on patch set 15 CR +1 V +1 09/13/24, 20:44
-
Stefan Bürk commented on patch set 15 09/13/24, 20:45
LinktypeInterface.php:87ReplyDone -
Stefan Bürk uploaded patch set 16
CR +1V +109/13/24, 20:46 -
Stefan Bürk voted on patch set 16 CR +1 V +1 09/13/24, 20:47
-
Garvin Hicking voted on patch set 16 CR +1 V +1 09/13/24, 20:51
-
core-ci voted on patch set 16 V -1 09/13/24, 20:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65708
-
core-ci voted on patch set 16 V +1 09/13/24, 21:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65708
-
Stefan Bürk voted on patch set 16 CR +2 V +2 09/13/24, 21:12
-
Stefan Bürk merged patch set 17 09/13/24, 21:12