Review main Merged

82879[TASK] Do not force lightmode for examples

Benjamin Kott CR +2 V +2 Normal +49 −40 updated 02/13/24, 08:47

Commit message

The style guide should aid in testing and constructing backend components.
In this change, we're removing the mandatory light mode for examples to
enhance visibility of adjustments within sub-components.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 811

  1. Benjamin Kott uploaded patch set 1 02/09/24, 14:12

  2. core-ci voted on patch set 1 V +1 02/09/24, 14:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52964

  3. Benjamin Franzke commented on patch set 1 CR -1 02/09/24, 15:09

    _example.scss:35

    I'd like to see color-scheme added for darkmode scrollbar: ``` @media (prefers-color-scheme: dark) { color-scheme: dark; } ``` But that's going to be annoying for `[data-theme]` conditionals and probably deserves a mixin.

    _root.scss:192

    seems to be unused
  4. Benjamin Kott rebased onto patch set 2 CR -1 V +1 02/13/24, 08:27

  5. Benjamin Kott uploaded patch set 3 02/13/24, 08:27

  6. Benjamin Kott commented on patch set 3 02/13/24, 08:29

    _example.scss:35 Reply

    Done

    _root.scss:192 Reply

    Done
  7. core-ci voted on patch set 2 V +1 02/13/24, 08:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53129

  8. core-ci voted on patch set 3 V +1 02/13/24, 08:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53130

  9. Oli Bartsch voted on patch set 3 CR +1 V +1 02/13/24, 08:37

  10. Benjamin Franzke voted on patch set 3 CR +2 V +2 02/13/24, 08:46

  11. Benjamin Franzke merged patch set 4 02/13/24, 08:47