Review main Merged

82884[BUGFIX] Wrong language labels in StandardContentPreviewRenderer

Torben Hansen CR +2 V +2 Easy +4 −4 updated 02/10/24, 23:15

Commit message

The language labels for `noPluginSelected` and `edit` in
StandardContentPreviewRenderer can not be resolved, because the
extension path is wrong.

This change fixes the extension path and additionally streamlines
one label output, by using `htmlspecialchars` to escape the
generated label similar to the other label output in this class.

Additionally a similar wrong extension path in
`ExampleLinkType.rst.txt` has been adapted.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Benni Mack +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 912

  1. Torben Hansen uploaded patch set 1 02/09/24, 18:21

  2. core-ci voted on patch set 1 V +1 02/09/24, 18:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52981

  3. Christian Kuhn updated the commit message in patch set 2 V +1 02/10/24, 06:41

  4. Christian Kuhn commented on patch set 2 CR -1 02/10/24, 06:41

    let's fix the other place too, please.

    StandardContentPreviewRenderer.php:382

    that one is broken, too.
  5. Christian Kuhn commented on patch set 2 02/10/24, 06:44

    and maybe the example in typo3/sysext/linkvalidator/Documentation/CodeSnippets/Examples/ExampleLinkType.rst.txt along the way. see https://review.typo3.org/c/Packages/TYPO3.CMS/+/78759 which introduced these bugs.
  6. core-ci voted on patch set 2 V +1 02/10/24, 06:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53001

  7. Torben Hansen uploaded patch set 3 CR -1 V +1 02/10/24, 08:04

  8. Torben Hansen commented on patch set 2 02/10/24, 08:05

    Reply

    Done

    Reply

    Done

    StandardContentPreviewRenderer.php:382 Reply

    Done
  9. core-ci voted on patch set 3 V +1 02/10/24, 08:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53004

  10. Benni Mack voted on patch set 3 CR +1 V +1 02/10/24, 21:45

  11. Stefan Bürk voted on patch set 3 CR +2 V +2 02/10/24, 23:00

  12. Stefan Bürk merged patch set 4 02/10/24, 23:15