Review main Merged

82888[TASK] Reduce TCA ctrl origUid usages

Christian Kuhn CR +2 V +2 Impossible +8631 −8754 updated 02/13/24, 12:58

Commit message

The database column defined by TCA ctrl 'origUid'
('t3_origuid') had a bumpy ride over the years.

It was mostly obsoleted in v8 with the introduction of
'translationSource' ('l10n_source'). A patch to fully
remove it with #88495 has been reverted with #88501,
leaving the field in limbo.

The only remaining "true" usage of 'origUid' is in an
inline relation scenario in DataMapProcessor when an
inline parent *is* localizable (TCA ctrl 'languageField'
and 'transOrigPointerField' set), but a child *is not*:
Due to the copy strategy of all inline children upon
localization of a parent record, the core needs to know
if a child exists already or needs to be created. 'origUid'
then stores the uid of the default language child. A couple
of tests refer to this scenario as "monoglot" children.

We could potentially get rid of that scenario by
postulating that an inline child has to be localizable
as well if the parent is, but that decision can be
taken later.

The patch does not touch this scenario, but looks at
'origUid' from a different perspective: If a table *is*
localizable, or is not used as inline child, then 'origUid'
is not needed. The patch thus removes TCA ctrl 'origUid'
from TCA tables, keeping it only in the test scenario
extensions 'test_irre_csv', 'test_irre_foreignfield' and
'test_irre_foreignfield_non_ws'.

The bulk of the patch is about removing 't3_origuid' from
the functional test .csv fixture files, while the most
important TCA changes are dropping ctrl 'origUid' from
table 'pages' and 'tt_content'.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 5

Files 687

Show 667 more files

Review log 3356

Show 1731 earlier messages
  1. Christian Kuhn uploaded patch set 1 02/10/24, 07:00

  2. core-ci voted on patch set 1 V -1 02/10/24, 07:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53002

  3. Christian Kuhn uploaded patch set 2 V -1 02/10/24, 07:10

  4. core-ci voted on patch set 2 V -1 02/10/24, 07:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53003

  5. Christian Kuhn uploaded patch set 3 V -1 02/10/24, 09:41

  6. core-ci voted on patch set 3 V -1 02/10/24, 09:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53005

  7. Christian Kuhn uploaded patch set 4 V -1 02/10/24, 10:46

  8. Christian Kuhn commented on patch set 4 02/10/24, 10:51

    pages done. +3363 -3364
  9. core-ci voted on patch set 4 V +1 02/10/24, 10:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53006

  10. Christian Kuhn uploaded patch set 5 V +1 02/10/24, 10:57

  11. core-ci voted on patch set 5 V -1 02/10/24, 11:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53007

  12. Christian Kuhn uploaded patch set 6 V -1 02/10/24, 11:29

  13. core-ci voted on patch set 6 V -1 02/10/24, 11:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53008

  14. Christian Kuhn uploaded patch set 7 V -1 02/10/24, 15:36

  15. Christian Kuhn commented on patch set 7 02/10/24, 15:40

    tt_content done +7894 -7904
  16. core-ci voted on patch set 7 V +1 02/10/24, 15:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53017

  17. Christian Kuhn uploaded patch set 8 V +1 02/10/24, 15:48

  18. core-ci voted on patch set 8 V -1 02/10/24, 15:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53018

  19. Christian Kuhn uploaded patch set 9 V -1 02/10/24, 15:58

  20. Christian Kuhn uploaded patch set 10 02/10/24, 16:03

  21. Christian Kuhn commented on patch set 10 02/10/24, 16:04

    sys_category +8215 -8226
  22. core-ci voted on patch set 9 V -1 02/10/24, 16:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53019

  23. core-ci voted on patch set 10 V +1 02/10/24, 16:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53020

  24. Christian Kuhn uploaded patch set 11 V +1 02/10/24, 16:12

  25. Christian Kuhn uploaded patch set 12 02/10/24, 16:18

  26. core-ci voted on patch set 11 V -1 02/10/24, 16:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53021

  27. core-ci voted on patch set 12 V +1 02/10/24, 16:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53024

  28. Christian Kuhn uploaded patch set 13 V +1 02/10/24, 16:32

  29. core-ci voted on patch set 13 V +1 02/10/24, 16:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53025

  30. Christian Kuhn uploaded patch set 14 V +1 02/10/24, 16:43

  31. core-ci voted on patch set 14 V +1 02/10/24, 16:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53028

  1. Christian Kuhn uploaded patch set 15 V +1 02/10/24, 16:53

  2. core-ci voted on patch set 15 V +1 02/10/24, 17:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53029

  3. Christian Kuhn uploaded patch set 16 V +1 02/10/24, 17:06

  4. core-ci voted on patch set 16 V +1 02/10/24, 17:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53030

  5. Christian Kuhn uploaded patch set 17 V +1 02/10/24, 17:19

  6. core-ci voted on patch set 17 V +1 02/10/24, 17:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53033

  7. Christian Kuhn uploaded patch set 18 V +1 02/11/24, 05:46

  8. core-ci voted on patch set 18 V +1 02/11/24, 05:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53046

  9. Christian Kuhn uploaded patch set 19 V +1 02/11/24, 06:31

  10. core-ci voted on patch set 19 V +1 02/11/24, 06:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53047

  11. Christian Kuhn uploaded patch set 20 V +1 02/11/24, 06:56

  12. core-ci voted on patch set 20 V +1 02/11/24, 07:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53048

  13. Christian Kuhn uploaded patch set 21 V +1 02/11/24, 08:00

  14. Christian Kuhn updated the commit message in patch set 22 02/11/24, 08:04

  15. core-ci voted on patch set 21 V +1 02/11/24, 08:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53049

  16. core-ci voted on patch set 22 V +1 02/11/24, 08:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53050

  17. Jo Hasenau commented on patch set 22 CR -1 02/12/24, 08:57

    Since this field is an essential part of the work currently done for the TransFusion wizard, I will set this to -1 as a remark. We should discuss the situation a bit more detailed though, which might be better to do outside of the review tracker.
  18. Jo Hasenau commented on patch set 22 CR +1 02/12/24, 15:39

    We discussed the impact of the changes on the TransFusion extension and came to the conclusion, that the wizard needs a confirmation step anyway, because the information in t3_origUid might not be as reliable as expected. So the patch wouldn't hurt that much anymore.
  19. Christian Kuhn uploaded patch set 23 CR +1 V +1 02/13/24, 11:20

  20. core-ci voted on patch set 23 V +1 02/13/24, 11:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53162

  21. Stefan Bürk voted on patch set 23 CR +1 V +1 02/13/24, 11:41

  22. Oliver Klee voted on patch set 23 V +1 02/13/24, 12:33

  23. Benni Mack voted on patch set 23 CR +1 V +1 02/13/24, 12:44

  24. Christian Kuhn voted on patch set 23 CR +2 V +2 02/13/24, 12:44

  25. Christian Kuhn merged patch set 24 02/13/24, 12:58