Review 12.4 Merged

82890[BUGFIX] Avoid static calls to LogDataTrait::formatLogDetails

Oliver Hader CR +2 V +2 Easy +2 −2 updated 02/10/24, 17:37

Commit message

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Benjamin Franzke +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Benjamin Franzke +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 810

  1. Oliver Hader uploaded patch set 1 02/10/24, 17:13

  2. Stefan Bürk voted on patch set 1 CR +1 V +1 02/10/24, 17:17

  3. core-ci voted on patch set 1 V +1 02/10/24, 17:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53031

  4. Benjamin Franzke commented on patch set 1 02/10/24, 17:23

    I understand the wording in the issue, but I. here it should be "avoid static calls" (..in object context)
  5. Oliver Hader updated the commit message in patch set 2 CR +1 V +1 02/10/24, 17:24

  6. Oliver Hader commented on patch set 2 02/10/24, 17:24

    Reply

    Thx
  7. Benjamin Franzke voted on patch set 2 CR +1 V +1 02/10/24, 17:25

  8. core-ci voted on patch set 2 V +1 02/10/24, 17:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53034

  9. Oliver Hader voted on patch set 2 CR +2 V +2 02/10/24, 17:37

  10. Oliver Hader merged patch set 3 02/10/24, 17:37