Review main Merged

82894[DOCS] Document how to replace a linktype

Sybille Peters CR +2 V +2 Normal +70 −2 updated 02/12/24, 08:38

Commit message

Since the linktypes are automatically registered in Linkvalidator,
it is no longer quite as easy to replace the "external" linktype.
You cannot register another linktype using the same identifier
"external", so a different identifier must be used.

A minimal example is added to the developer section in the
documentation.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Chris Müller +1
  • Verified V +2 Done
    • Benni Mack +2
    • Chris Müller +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 1319

  1. Sybille Peters uploaded patch set 1 02/11/24, 11:47

  2. Sybille Peters uploaded patch set 2 02/11/24, 11:49

  3. Sybille Peters uploaded patch set 3 02/11/24, 11:51

  4. core-ci voted on patch set 1 V +1 02/11/24, 11:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53057

  5. core-ci voted on patch set 2 V +1 02/11/24, 11:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53058

  6. core-ci voted on patch set 3 V +1 02/11/24, 11:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53059

  7. Chris Müller commented on patch set 3 CR -1 02/11/24, 15:20

    LinkTypeImplementation.rst:82

    Please use as caption: EXT:my_extension/...

    LinkTypeImplementation.rst:84

    Please add also a namespace, for example: MyVendor\MyExtension\Linkvalidator

    LinkTypeImplementation.rst:116

    Linkvalidator ExternalLinktype -> Linkvalidator's :php:`ExternalLinktype` (using the text role for better readability) Page TSconfig -> page TSconfig (perhaps you can link to the page TSconfig reference?)

    LinkTypeImplementation.rst:117

    :ts: -> :typoscript:

    LinkTypeImplementation.rst:118

    "If this is not the case ...". But when it is not the case? Either it is copied or not?

    LinkTypeImplementation.rst:119

    :ts: -> :typoscript:

    LinkTypeImplementation.rst:120

    In the header above you write "link type", here "linktype". Please be consistent. I would prefer "link type".
  8. Sybille Peters uploaded patch set 4 CR -1 V +1 02/12/24, 06:18

  9. Sybille Peters commented on patch set 3 02/12/24, 06:18

    LinkTypeImplementation.rst:82 Reply

    Done

    LinkTypeImplementation.rst:84 Reply

    Done

    LinkTypeImplementation.rst:116 Reply

    Done

    LinkTypeImplementation.rst:117 Reply

    Done

    LinkTypeImplementation.rst:118 Reply

    It should be copied (or otherwise defined) if the class does not inherit from Linkvalidator's ExternalLinktype. I added a code snippet, which hopefully makes it clearer.

    LinkTypeImplementation.rst:119 Reply

    Done

    LinkTypeImplementation.rst:120 Reply

    I am using "linktype", because this is already being used on the page. Have changed the 2 "link type" => "linktype"
  10. core-ci voted on patch set 4 V +1 02/12/24, 06:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53068

  11. Sybille Peters uploaded patch set 5 V +1 02/12/24, 07:16

  12. core-ci voted on patch set 5 V +1 02/12/24, 07:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53069

  13. Chris Müller uploaded patch set 6 V +1 02/12/24, 08:26

  14. Chris Müller commented on patch set 6 02/12/24, 08:28

    Added some line breaks to avoid horizontal scrolling in code blocks.
  15. core-ci voted on patch set 6 V +1 02/12/24, 08:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53070

  16. Chris Müller voted on patch set 6 CR +1 V +1 02/12/24, 08:32

  17. Benni Mack voted on patch set 6 CR +2 V +2 02/12/24, 08:38

  18. Benni Mack merged patch set 7 02/12/24, 08:38

  19. Benni Mack commented on patch set 7 02/12/24, 08:38

    Thank you, Sybille!