82894[DOCS] Document how to replace a linktype
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Chris Müller +1
-
Verified V +2 Done
- Benni Mack +2
- Chris Müller +1
- core-ci +1 CI
Issues 2
Files 3
Review log 1319
-
Sybille Peters uploaded patch set 1 02/11/24, 11:47
-
Sybille Peters uploaded patch set 2 02/11/24, 11:49
-
Sybille Peters uploaded patch set 3 02/11/24, 11:51
-
core-ci voted on patch set 1 V +1 02/11/24, 11:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53057
-
core-ci voted on patch set 2 V +1 02/11/24, 11:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53058
-
core-ci voted on patch set 3 V +1 02/11/24, 11:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53059
-
Chris Müller commented on patch set 3 CR -1 02/11/24, 15:20
LinkTypeImplementation.rst:84Please add also a namespace, for example: MyVendor\MyExtension\LinkvalidatorLinkTypeImplementation.rst:116Linkvalidator ExternalLinktype -> Linkvalidator's :php:`ExternalLinktype` (using the text role for better readability) Page TSconfig -> page TSconfig (perhaps you can link to the page TSconfig reference?)LinkTypeImplementation.rst:117:ts: -> :typoscript:LinkTypeImplementation.rst:118"If this is not the case ...". But when it is not the case? Either it is copied or not?LinkTypeImplementation.rst:119:ts: -> :typoscript:LinkTypeImplementation.rst:120In the header above you write "link type", here "linktype". Please be consistent. I would prefer "link type". -
Sybille Peters uploaded patch set 4
CR -1V +102/12/24, 06:18 -
Sybille Peters commented on patch set 3 02/12/24, 06:18
LinkTypeImplementation.rst:82ReplyDoneLinkTypeImplementation.rst:84ReplyDoneLinkTypeImplementation.rst:116ReplyDoneLinkTypeImplementation.rst:117ReplyDoneLinkTypeImplementation.rst:118ReplyIt should be copied (or otherwise defined) if the class does not inherit from Linkvalidator's ExternalLinktype. I added a code snippet, which hopefully makes it clearer.LinkTypeImplementation.rst:119ReplyDoneLinkTypeImplementation.rst:120ReplyI am using "linktype", because this is already being used on the page. Have changed the 2 "link type" => "linktype" -
core-ci voted on patch set 4 V +1 02/12/24, 06:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53068
-
Sybille Peters uploaded patch set 5
V +102/12/24, 07:16 -
core-ci voted on patch set 5 V +1 02/12/24, 07:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53069
-
Chris Müller uploaded patch set 6
V +102/12/24, 08:26 -
Chris Müller commented on patch set 6 02/12/24, 08:28
Added some line breaks to avoid horizontal scrolling in code blocks. -
core-ci voted on patch set 6 V +1 02/12/24, 08:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53070
-
Chris Müller voted on patch set 6 CR +1 V +1 02/12/24, 08:32
-
Benni Mack voted on patch set 6 CR +2 V +2 02/12/24, 08:38
-
Benni Mack merged patch set 7 02/12/24, 08:38
-
Benni Mack commented on patch set 7 02/12/24, 08:38
Thank you, Sybille!
LinkTypeImplementation.rst:82