Review main Merged

82896[BUGFIX] Enable action buttons in Linkvalidator module

Sybille Peters CR +2 V +2 Easy +14 −16 updated 03/11/24, 12:47

Commit message

The action buttons in the Linkvalidator module are
disabled in case all checkboxes are unchecked.

In case one of the checkboxes changes its state,
the state of the corresponding action button is
now properly updated.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1116

  1. Sybille Peters uploaded patch set 1 02/11/24, 13:58

  2. Sybille Peters updated the commit message in patch set 2 02/11/24, 13:59

  3. Sybille Peters updated the commit message in patch set 3 02/11/24, 14:01

  4. core-ci voted on patch set 1 V +1 02/11/24, 14:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53061

  5. core-ci voted on patch set 2 V +1 02/11/24, 14:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53062

  6. Sybille Peters wrote 02/11/24, 14:07

    Topic set to Linkvalidator
  7. core-ci voted on patch set 3 V +1 02/11/24, 14:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53063

  8. Oli Bartsch commented on patch set 3 V -1 02/15/24, 09:16

    Action button is still not enabled when checking the "toggleAll" checkbox
  9. Oli Bartsch uploaded patch set 4 V +1 02/15/24, 09:28

  10. Oli Bartsch commented on patch set 4 CR +1 V +1 02/15/24, 09:28

    Reply

    Done
  11. core-ci voted on patch set 4 V +1 02/15/24, 09:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53218

  12. Oli Bartsch rebased onto patch set 5 CR +1 V +1 03/03/24, 07:27

  13. core-ci voted on patch set 5 V +1 03/03/24, 07:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53785

  14. Oli Bartsch voted on patch set 5 CR +1 V +1 03/03/24, 12:59

  15. Christian Kuhn voted on patch set 5 CR +2 V +2 03/11/24, 12:47

  16. Christian Kuhn merged patch set 6 03/11/24, 12:47