Review main Merged

82897[BUGFIX] Do not try to log negative UID in DataHandler

Markus Klein CR +2 V +2 Easy +1 −1 updated 03/07/24, 18:51

Commit message

Ensure recuid is always int+ as the underlying
DB field is `unsigned`.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1417

  1. Markus Klein uploaded patch set 1 02/12/24, 10:55

  2. core-ci voted on patch set 1 V +1 02/12/24, 11:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53073

  3. Thomas Hohn voted on patch set 1 CR +1 02/12/24, 11:15

  4. Oliver Hader commented on patch set 1 CR -1 02/12/24, 11:42

    Using `0` (with this patch) would write invalid log entries... Negative UID values are used e.g. for inserting records after an existing record, e.g. `uid=-123` (negativ value) means to insert a new record after the existing record with `uid=123` (positive value). Thus - without testing the patch - to me it looks like those log invocations using a negative value should be streamlined or use a better/alternative log message...
  5. Markus Klein commented on patch set 1 02/12/24, 13:42

    Reply

    I prefer to loose information (with the 0) and have a log entry, instead of having no log entry and an error log instead. :-) 0 is at least technically feasible and is described as "Record UID. Zero if NA"
  6. Oliver Hader voted on patch set 1 CR 0 02/12/24, 15:11

  7. Oliver Hader commented on patch set 1 02/12/24, 15:12

    Removing my -1 vote since I don't have time for providing a better solution and did not want to block this patch...
  8. Markus Klein commented on patch set 1 02/12/24, 15:48

    Reply

    The patch is a quick-fix only. A drive-by change, because I found this error on a customer instance today. I didn't spend the time to analyze how a better solution might look like. So, I absolutely no problem letting this change "hang" a bit, until we find a better solution.
  9. Christian Kuhn commented on patch set 1 03/07/24, 18:11

    Reply

    i think abs() should do ... negative uid's for 'move' are not allowed and should except, but as a bugfix, logging an abs() version of it should be ok for now.
  10. Christian Kuhn commented on patch set 1 03/07/24, 18:11

    Reply

    Done
  11. Christian Kuhn uploaded patch set 2 CR +1 V +1 03/07/24, 18:13

  12. Christian Kuhn updated the commit message in patch set 3 03/07/24, 18:14

  13. core-ci voted on patch set 2 V +1 03/07/24, 18:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54166

  14. core-ci voted on patch set 3 V +1 03/07/24, 18:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/54167

  15. Benni Mack voted on patch set 3 CR +1 V +1 03/07/24, 18:22

  16. Christian Kuhn voted on patch set 3 CR +2 V +2 03/07/24, 18:51

  17. Christian Kuhn merged patch set 4 03/07/24, 18:51