82932[TASK] Update `phpstan/phpstan` version
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Benjamin Franzke +1
- Anja Leichsenring +1
-
Verified V +2 Done
- Stefan Bürk +2
- Benjamin Franzke +1
- Anja Leichsenring +1
- core-ci +1 CI
Issues 1
Files 4
Review log 2026
Show 1 earlier messages
-
Stefan Bürk uploaded patch set 1 02/13/24, 05:39
-
core-ci voted on patch set 1 V +1 02/13/24, 05:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53109
-
Stefan Bürk uploaded patch set 2
V +102/13/24, 05:46 -
core-ci voted on patch set 2 V +1 02/13/24, 05:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53111
-
Anja Leichsenring updated the commit message in patch set 3
V +102/13/24, 06:06 -
Anja Leichsenring voted on patch set 3 CR +1 V +1 02/13/24, 06:06
-
core-ci voted on patch set 3 V +1 02/13/24, 06:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53114
-
Benjamin Franzke commented on patch set 3 CR -1 02/13/24, 06:12
-
Benjamin Franzke commented on patch set 3 02/13/24, 06:14
FormEditorController.php:314ReplyReason for this misunderstanding is a false docblock in line 280: ``` /** @var array<string, array<string, string>> $formElementsByGroup */ ``` While line 296 the inserts another structure. The correct fix is to drop the 280 line or to make that a correct @var statement. -
Stefan Bürk commented on patch set 3 02/13/24, 06:29
FormEditorController.php:314ReplyEither the docblock in L280 is wrong or the assignment in 296 - but I'd say it's possible to have multiple elements per group so that 296 should be correct and the correct docblock should be ``` /** @var array<string, list<array<string, string>>> */ ``` The `unset()` is not needed and wrong, because `$formElementsByGroup[$groupName]` is an array of elements - and has no `sorting` key set directly. The structure build in the first foreach loop is ``` $formElementsByGroup = [ 'group-name-1' => [ [ 'key' => '', 'cssKey' => '', 'label' => '', 'sorting' => '', 'iconIdentifier' => '', ], [ 'key' => '', 'cssKey' => '', 'label' => '', 'sorting' => '', 'iconIdentifier' => '', ], ], 'group-name-2' => [ [ 'key' => '', 'cssKey' => '', 'label' => '', 'sorting' => '', 'iconIdentifier' => '', ], [ 'key' => '', 'cssKey' => '', 'label' => '', 'sorting' => '', 'iconIdentifier' => '', ], ], ] ``` and `unset($formElementsByGroup[$groupName]['sorting')` will never ever remove anything as tha array is index based and not associative - not having an `sorting` key. What do you think ? -
Benjamin Franzke commented on patch set 3 02/13/24, 06:29
also 13.0 -
Stefan Bürk uploaded patch set 4
CR +1V +102/13/24, 06:33 -
Stefan Bürk updated the commit message in patch set 5 02/13/24, 06:34
-
Stefan Bürk commented on patch set 5 02/13/24, 06:39
Reply
Done -
core-ci voted on patch set 5 V +1 02/13/24, 06:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53118
-
core-ci voted on patch set 4 V +1 02/13/24, 06:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53116
-
Thomas Hohn voted on patch set 5 CR +1 V +1 02/13/24, 06:55
-
Benjamin Franzke commented on patch set 5 02/13/24, 06:57
FormEditorController.php:280As `sorting` will be an integer (coming from yaml parser) this should probably be `mixed`. Or maybe better: ``` array{key: string, cssKey: string, label: string, sorting: int, iconIdentifier: string} ```FormEditorController.php:314ReplyOk Alright, thank you! -
Stefan Bürk commented on patch set 6
CR +1V +102/13/24, 07:01Published edit on patch set 5. -
core-ci voted on patch set 6 V +1 02/13/24, 07:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53121
-
Stefan Bürk commented on patch set 6 02/13/24, 07:11
FormEditorController.php:280ReplyDone -
Benjamin Franzke voted on patch set 6 CR +1 02/13/24, 07:17
-
Benjamin Franzke voted on patch set 6 V +1 02/13/24, 07:19
-
Anja Leichsenring voted on patch set 6 CR +1 V +1 02/13/24, 07:22
-
Stefan Bürk voted on patch set 6 CR +2 V +2 02/13/24, 07:25
-
Stefan Bürk merged patch set 7 02/13/24, 07:25
FormEditorController.php:314