Review 12.4 Merged

82933[TASK] Update `phpstan/phpstan` version

Stefan Bürk CR +2 V +2 Easy +8 −14 updated 02/13/24, 07:25

Commit message

A new PHPStan version has been releases,
which is pulled in automatically in the
composerInstallMax nightly test.

The higher version allows to remove a
ignore pattern from the baseline and
a superfluous key unset is detected.

This change raises the PHPStan version,
removes the superfluous `unset()` and
regenerates the baseline to remove the
invalid ignore pattern.

Used command(s):

> Build/Scripts/runTests.sh -s composer \
    -- require --dev "phpstan/phpstan":"^1.10.58"
> Build/Scripts/runTests.sh \
    -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 4

Review log 914

  1. Stefan Bürk uploaded patch set 1 02/13/24, 05:47

  2. core-ci voted on patch set 1 V +1 02/13/24, 05:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53112

  3. Anja Leichsenring updated the commit message in patch set 2 V +1 02/13/24, 06:06

  4. Anja Leichsenring voted on patch set 2 CR +1 V +1 02/13/24, 06:06

  5. core-ci voted on patch set 2 V +1 02/13/24, 06:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53115

  6. Stefan Bürk uploaded patch set 3 CR +1 V +1 02/13/24, 06:33

  7. Stefan Bürk updated the commit message in patch set 4 02/13/24, 06:36

  8. core-ci voted on patch set 3 V +1 02/13/24, 06:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53117

  9. core-ci voted on patch set 4 V +1 02/13/24, 06:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53119

  10. Thomas Hohn voted on patch set 4 CR +1 V +1 02/13/24, 06:54

  11. Stefan Bürk commented on patch set 5 CR +1 V +1 02/13/24, 07:11

    Published edit on patch set 4.
  12. core-ci voted on patch set 5 V +1 02/13/24, 07:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53123

  13. Stefan Bürk voted on patch set 5 CR +2 V +2 02/13/24, 07:25

  14. Stefan Bürk merged patch set 6 02/13/24, 07:25