Review 13.0 Merged

82935[TASK] Update `phpstan/phpstan` version

Stefan Bürk CR +2 V +2 Easy +8 −14 updated 02/13/24, 07:25

Commit message

A new PHPStan version has been released,
which is pulled in automatically in the
composerInstallMax nightly test.

The higher version allows to remove a
ignore pattern from the baseline and
a superfluous key unset is detected.

This change raises the PHPStan version,
removes the superfluous `unset()` and
regenerates the baseline to remove the
invalid ignore pattern.

Used command(s):

> Build/Scripts/runTests.sh -s composer \
    -- require --dev "phpstan/phpstan":"^1.10.58"
> Build/Scripts/runTests.sh \
    -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 4

Review log 46

  1. Stefan Bürk uploaded patch set 1 02/13/24, 06:40

  2. core-ci voted on patch set 1 V +1 02/13/24, 06:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53120

  3. Stefan Bürk commented on patch set 2 V +1 02/13/24, 07:11

    Published edit on patch set 1.
  4. core-ci voted on patch set 2 V +1 02/13/24, 07:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53122

  5. Stefan Bürk voted on patch set 2 CR +2 V +2 02/13/24, 07:25

  6. Stefan Bürk merged patch set 3 02/13/24, 07:25