Review 12.4 Merged Breaking

82945[!!!][SECURITY] Enforce absolute path checks in FAL local driver

Oliver Hader CR +2 V +2 Normal +127 −7 updated 02/13/24, 09:51

Commit message

The File Abstraction Layer Local Driver did not verify whether
a given absolute file path is allowed, and made it possible to
access files outside of the project path, and to by-pass the
setting in $GLOBALS['TYPO3_CONF_VARS']['BE']['lockRootPath'].

In case lockRootPath is not set, any local file path must be
at least located in the base directory of the current project.

The lockRootPath setting now supports array values as well.

The trailing slash is enforced automatically. Example:
* instead of 'lockRootPath=/var/spe' previously matching
  the paths '/var/specs/'  and '/var/specials/,
* now both paths need to be declared explicitly, since
  'lockRootPath=/var/spe' is evaluated as '/var/spe/'

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2

Issues 1

Files 8

Review log 34

  1. Oliver Hader uploaded patch set 1 02/13/24, 09:05

  2. Oliver Hader commented on patch set 1 CR +2 V +2 02/13/24, 09:05

    Auto-approved
  3. Oliver Hader merged patch set 2 02/13/24, 09:05

  4. core-ci voted on patch set 1 V +1 02/13/24, 09:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53137