Review 12.4 Merged

82948[SECURITY] Do not disclose encryptionKey via InstallTool

Oliver Hader CR +2 V +2 Easy +21 −5 updated 02/13/24, 09:29

Commit message

The encryptionKey is a secret that must never be sent within any
request, therefore it is now dropped from the editing interface in
"Configure Installation-Wide Options".

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2

Issues 1

Files 6

Review log 34

  1. Oliver Hader uploaded patch set 1 02/13/24, 09:06

  2. Oliver Hader commented on patch set 1 CR +2 V +2 02/13/24, 09:06

    Auto-approved
  3. Oliver Hader merged patch set 2 02/13/24, 09:06

  4. core-ci voted on patch set 1 V +1 02/13/24, 09:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53140