Review 13.0 Merged

82954[SECURITY] Do not disclose encryptionKey via InstallTool

Oliver Hader CR +2 V +2 Easy +12 −5 updated 02/13/24, 09:40

Commit message

The encryptionKey is a secret that must never be sent within any
request, therefore it is now dropped from the editing interface in
"Configure Installation-Wide Options".

The log file writer has been adapted to be aware of the fact that the
encryption key might not be set when TYPO3 has not yet been installed
(which is the case when `vendor/bin/typo3 setup` is executed).

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2

Issues 1

Files 4

Review log 34

  1. Oliver Hader uploaded patch set 1 02/13/24, 09:07

  2. Oliver Hader commented on patch set 1 CR +2 V +2 02/13/24, 09:07

    Auto-approved
  3. Oliver Hader merged patch set 2 02/13/24, 09:07

  4. core-ci voted on patch set 1 V +1 02/13/24, 09:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53146