Review main Abandoned

82970[TASK] Use data handler for creating be_users

Lukas Maxheim CR 0 V 0 Easy +28 −13 updated 02/13/24, 12:04

Commit message

This change introduces the use of the data handler instead of using the
query builder when creating backend users via backend:user:create.

This ensures that the user is initialized properly and the creation of
the new user is logged to the TYPO3 log and the history of the user
record.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 45

  1. Lukas Maxheim uploaded patch set 1 02/13/24, 11:34

  2. core-ci voted on patch set 1 V +1 02/13/24, 11:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53163

  3. Mathias Brodala commented on patch set 1 CR -1 02/13/24, 11:41

    CreateBackendUserCommand.php:347 Unresolved

    This check can be dropped, the "email" column is of TCA type "email" which validates the input already.

    CreateBackendUserCommand.php:349 Unresolved

    Here we can pass through the incoming array instead.

    CreateBackendUserCommand.php:351 Unresolved

    These two should be removed, the DataHandler manages these instead.

    CreateBackendUserCommand.php:361 Unresolved

    We should resolve this using the StringUtility::getUniqueId('NEW') used above instead. (Which then must be stored in a variable.)
  4. Lukas Maxheim commented on patch set 1 02/13/24, 11:57

    Sorry for the inconvenience, I'm still new to the process and actually wanted to add the changes as a new patch to https://review.typo3.org/c/Packages/TYPO3.CMS/+/82822. I have submitted further patches there that take your comments into account. Feel free to close this ... Kind regards Lukas
  5. Lukas Maxheim abandoned the change 02/13/24, 12:04