82970[TASK] Use data handler for creating be_users
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 45
-
Lukas Maxheim uploaded patch set 1 02/13/24, 11:34
-
core-ci voted on patch set 1 V +1 02/13/24, 11:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53163
-
Mathias Brodala commented on patch set 1 CR -1 02/13/24, 11:41
CreateBackendUserCommand.php:349UnresolvedHere we can pass through the incoming array instead.CreateBackendUserCommand.php:351UnresolvedThese two should be removed, the DataHandler manages these instead.CreateBackendUserCommand.php:361UnresolvedWe should resolve this using the StringUtility::getUniqueId('NEW') used above instead. (Which then must be stored in a variable.) -
Lukas Maxheim commented on patch set 1 02/13/24, 11:57
Sorry for the inconvenience, I'm still new to the process and actually wanted to add the changes as a new patch to https://review.typo3.org/c/Packages/TYPO3.CMS/+/82822. I have submitted further patches there that take your comments into account. Feel free to close this ... Kind regards Lukas -
Lukas Maxheim abandoned the change 02/13/24, 12:04
This should be patch to https://review.typo3.org/c/Packages/TYPO3.CMS/+/82822
CreateBackendUserCommand.php:347Unresolved