Review 12.4 Merged

82977[TASK] Stop runtime caching GU::trimExplode() in DH

Christian Kuhn CR +2 V +2 Easy +4 −25 updated 02/15/24, 12:03

Commit message

There is no point to substitute GU::trimExplode() of
the rather short TCA 'eval' string by substituting
it with an md5() operation plus runtime cache object
operations.

Both things are most likely similarily quick, and
the time consumed by queries in DH is multiple orders
of magnitude bigger than this simple operation, a
difference is not measurable.

Let's thus simplify the code a bit.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 45

  1. Christian Kuhn commented on patch set 1 02/15/24, 11:51

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 02/15/24, 11:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53228

  3. Oliver Klee voted on patch set 1 CR +1 V +1 02/15/24, 11:57

  4. Christian Kuhn voted on patch set 1 CR +2 V +2 02/15/24, 12:03

  5. Christian Kuhn merged patch set 2 02/15/24, 12:03