Review 12.4 Merged

82994[BUGFIX] Respect TCA type `group` as `foreign_selector`

Oli Bartsch CR +2 V +2 Normal +115 −7 updated 02/14/24, 07:28

Commit message

It's now possible to use a TCA type `group`
field as `foreign_selector` together with
the `useCombination` functionality. The
corresponding "child child table" information
is in this case fetched from the `allowed`
option.

Side note: Using TCA type `group` for a
`foreign_selector` field is not really
documented, but it's also not forbidden.
Actually, it's a valid use case and also
working quite well as the new styleguide
examples demonstrate.

However, the documentation should be adjusted
to mention that only one table can be defined
in `allowed` for such fields.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 34

  1. Oli Bartsch uploaded patch set 1 02/14/24, 07:21

  2. core-ci voted on patch set 1 V +1 02/14/24, 07:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53188

  3. Oli Bartsch voted on patch set 1 CR +2 V +2 02/14/24, 07:28

  4. Oli Bartsch merged patch set 2 02/14/24, 07:28