Review main Merged

83002[BUGFIX] Use `form-select` for EXT:form "version2" select elements

Oli Bartsch CR +2 V +2 Easy +3 −3 updated 02/15/24, 10:17

Commit message

The EXT:form "version2" is using bootstrap 5,
which requires <select> elements to use the
`form-select` class. This is now fixed for
corresponding form elements.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Andreas Kienast +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 79

  1. Oli Bartsch uploaded patch set 1 02/14/24, 17:08

  2. core-ci voted on patch set 1 V +1 02/14/24, 17:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53203

  3. Oli Bartsch updated the commit message in patch set 2 V +1 02/15/24, 08:56

  4. core-ci voted on patch set 2 V +1 02/15/24, 09:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53216

  5. Andreas Kienast voted on patch set 2 CR +1 V +1 02/15/24, 09:08

  6. Benni Mack voted on patch set 2 CR +1 V +1 02/15/24, 09:35

  7. Jochen Roth voted on patch set 2 CR +1 V +1 02/15/24, 10:02

  8. Oli Bartsch voted on patch set 2 CR +2 V +2 02/15/24, 10:17

  9. Oli Bartsch merged patch set 3 02/15/24, 10:17