Review main Abandoned

83003[BUGFIX] Configuration parser must handle quoted lists correctly

Markus Klein CR 0 V 0 Easy +4 −8 updated 06/10/25, 08:23

Commit message

The Install Tool LocalConfigurationValueService must
be able to handle comma-separated lists for array-typed configuration,
which contain comma its parts. (CSV)

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 1619

  1. Markus Klein uploaded patch set 1 02/14/24, 19:35

  2. core-ci voted on patch set 1 V -1 02/14/24, 19:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53206

  3. Markus Klein uploaded patch set 2 V -1 02/14/24, 19:59

  4. Markus Klein marked it ready for review 02/14/24, 20:01

  5. core-ci voted on patch set 2 V +1 02/14/24, 20:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53207

  6. Benjamin Franzke commented on patch set 2 CR +1 V +1 02/14/24, 21:13

    Good idea! We planned to provide a proper interface for array-based configuration in v13 later on, but this is a good midterm solution, where we thought no one needs commas, so the current limitations of `type: array` wouldn't hurt too much – but that was obviously wrong :\
  7. Markus Klein commented on patch set 2 02/14/24, 21:50

    Reply

    Thanks. Well, it is always the same. Whenever I read explode, I already assume the code is broken. There are only few cases where the separator is really, for sure, not part of the user-data. It basically always needs CSV. (OT: all searches in Core are basically broken in this regard, where space is used as separator)
  8. Oli Bartsch commented on patch set 2 02/15/24, 08:06

    This now leads to whenever execute "Write configuration" in the install tool, a couple of unrelated settings (e.g. FE/cacheHash/excludedParameters) gets updated (at least corresponding notifications show up).
  9. Oli Bartsch commented on patch set 2 02/15/24, 08:54

    Reply

    unresolve comment
  10. Oliver Hader commented on patch set 2 02/15/24, 09:27

    LocalConfigurationValueService.php:197

    It feels like having tests for the CSV encoding-decoding roundtrip would be great - for instance it would be interesting how the `escape` attribute of `str_getcsv` actually would have an impact on CSV enclosures `"`
  11. Markus Klein commented on patch set 2 02/15/24, 09:32

    Reply

    Yes that's for sure.

    LocalConfigurationValueService.php:197 Reply Unresolved

    I thought about tests too, but the code is so nested that I did not attempt to do a full refactoring.
  12. Benjamin Franzke voted on patch set 2 CR 0 V 0 02/19/24, 15:35

  13. Markus Klein updated the commit message in patch set 3 V +1 08/07/24, 14:08

  14. core-ci voted on patch set 3 V -1 08/07/24, 14:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62997

  15. Benni Mack updated the commit message in patch set 4 V -1 10/18/24, 13:42

  16. Benni Mack commented on patch set 4 04/11/25, 21:19

    Please decide if we want to continue this approach (= set it to WIP) or come up with a new approach
  17. Markus Klein commented on patch set 4 04/13/25, 18:47

    Reply Unresolved

    I think I wouldn't mind those other values being updated
    @benni@typo3.org I can't descide this. I see no way to write a test in this case.
  18. Garvin Hicking commented on patch set 4 04/13/25, 19:03

    Reply

    (The approach in https://review.typo3.org/c/Packages/TYPO3.CMS/+/89040 could theoretically make this obsolete, if we manage key and values with distinct input fields that don't need an kind of implode/explode handling)
  19. Markus Klein abandoned the change 06/10/25, 08:23