83003[BUGFIX] Configuration parser must handle quoted lists correctly
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 1619
-
Markus Klein uploaded patch set 1 02/14/24, 19:35
-
core-ci voted on patch set 1 V -1 02/14/24, 19:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53206
-
Markus Klein uploaded patch set 2
V -102/14/24, 19:59 -
Markus Klein marked it ready for review 02/14/24, 20:01
-
core-ci voted on patch set 2 V +1 02/14/24, 20:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53207
-
Benjamin Franzke commented on patch set 2 CR +1 V +1 02/14/24, 21:13
Good idea! We planned to provide a proper interface for array-based configuration in v13 later on, but this is a good midterm solution, where we thought no one needs commas, so the current limitations of `type: array` wouldn't hurt too much – but that was obviously wrong :\ -
Markus Klein commented on patch set 2 02/14/24, 21:50
Reply
Thanks. Well, it is always the same. Whenever I read explode, I already assume the code is broken. There are only few cases where the separator is really, for sure, not part of the user-data. It basically always needs CSV. (OT: all searches in Core are basically broken in this regard, where space is used as separator) -
Oli Bartsch commented on patch set 2 02/15/24, 08:06
This now leads to whenever execute "Write configuration" in the install tool, a couple of unrelated settings (e.g. FE/cacheHash/excludedParameters) gets updated (at least corresponding notifications show up). -
Oli Bartsch commented on patch set 2 02/15/24, 08:54
Reply
unresolve comment -
Oliver Hader commented on patch set 2 02/15/24, 09:27
LocalConfigurationValueService.php:197It feels like having tests for the CSV encoding-decoding roundtrip would be great - for instance it would be interesting how the `escape` attribute of `str_getcsv` actually would have an impact on CSV enclosures `"` -
Markus Klein commented on patch set 2 02/15/24, 09:32
Reply
Yes that's for sure.LocalConfigurationValueService.php:197Reply UnresolvedI thought about tests too, but the code is so nested that I did not attempt to do a full refactoring. -
Benjamin Franzke voted on patch set 2 CR 0 V 0 02/19/24, 15:35
-
Markus Klein updated the commit message in patch set 3
V +108/07/24, 14:08 -
core-ci voted on patch set 3 V -1 08/07/24, 14:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62997
-
Benni Mack updated the commit message in patch set 4
V -110/18/24, 13:42 -
Benni Mack commented on patch set 4 04/11/25, 21:19
Please decide if we want to continue this approach (= set it to WIP) or come up with a new approach -
Markus Klein commented on patch set 4 04/13/25, 18:47
Reply Unresolved
I think I wouldn't mind those other values being updated@benni@typo3.org I can't descide this. I see no way to write a test in this case. -
Garvin Hicking commented on patch set 4 04/13/25, 19:03
Reply
(The approach in https://review.typo3.org/c/Packages/TYPO3.CMS/+/89040 could theoretically make this obsolete, if we manage key and values with distinct input fields that don't need an kind of implode/explode handling) -
Markus Klein abandoned the change 06/10/25, 08:23
Has been tackled with https://review.typo3.org/c/Packages/TYPO3.CMS/+/89040