Review main Merged

83004[TASK] Block *.neon files from root htaccess/web-config

Elias Häußler CR +2 V +2 Easy +3 −3 updated 10/16/24, 07:04

Commit message

Those file types belong to code quality check tools (most noticable
phpstan) and should never be served by browser requests.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 2633

Show 78 earlier messages
  1. Elias Häußler uploaded patch set 1 02/15/24, 07:31

  2. core-ci voted on patch set 1 V +1 02/15/24, 07:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53213

  3. Guido Schmechel voted on patch set 1 CR +1 02/15/24, 11:54

  4. Garvin Hicking commented on patch set 1 02/16/24, 08:14

    Since this is only relevant to fresh installs it's not breaking and wouldn't need an ReST entry. But maybe for existing installations this would be worth mentioning in an ReST that people might want to add this to their existing configs? (for composer-based installs in v12+ this change probably won't affect much because only Resources/Public of extensions are exposed, and these directories shouldn't contain files like .neon; for legacy mode it's good of course)
  5. Oliver Klee voted on patch set 1 CR +1 02/16/24, 09:40

  6. Benni Mack commented on patch set 1 02/16/24, 12:04

    How can I reproduce this? A non-composer based installation with a custom third party extension that ships a .neon file in the extension directory? Do you have an example?
  7. Elias Häußler commented on patch set 1 02/16/24, 12:27

    Reply

    Yes, should be reproducible with * TYPO3 >= v12 (classic mode) or * TYPO3 v11 (either classic mode or composer mode) and a third party extension with a \*.neon file in the extension directory. You can try this with every public extension that ships a \*.neon file, e.g. `composer req eliashaeussler/typo3-warming --prefer-source` (mind the `--prefer-source`, because `phpstan.neon` is excluded in dist archives).

    Reply

    I can add an Important.rst, if you consider this a useful addition to the patch :)
  8. Benjamin Franzke commented on patch set 1 02/17/24, 08:54

    Reply

    As described in https://review.typo3.org/c/Packages/TYPO3.CMS/+/83004/1#message-e0f74e236c5806c655adeb0470d6379f9d2166c1 – the usecases are so rare, that this is not worth a Important.rst in my opinion.

    Reply

    I'm not against this change (helps against fingerprinting extensions), but in general extensions should exclude those files from packaging, as you already did (https://github.com/eliashaeussler/typo3-warming/blob/main/.gitattributes#L23). `--prefer-source` is of course an issue, but basically only applies to v11-composer mode, since v11/v12 classic mode cannot use prefer-source and v12 wouldn't be affected. I think we should actually start to trim-down the root-htaccess for composer anyway, and start to trust our approach to symlink public resources only. That means we would run less useless regexes on every request in composer mode. Therefore it's fine for me to add even more to the blocklist.
    13.0 will not receive regular maintainance releases (only security releases until 13.1 is released), no need for backports to that branch.
  1. Elias Häußler updated the commit message in patch set 2 CR +1 V +1 02/19/24, 15:02

  2. Elias Häußler commented on patch set 2 02/19/24, 15:02

    Reply

    Other common use-cases are custom project-based extensions. For example, all extensions we develop for our clients are directly installed from their respective GitLab repository via Composer. If no [`gitlab-domains`][1] are configured in a root `composer.json`, Composer automatically switches to `prefer-source` and installs the extension from source, ignoring all potential rules from `.gitattributes`. [1]: https://getcomposer.org/doc/06-config.md#gitlab-domains

    Reply

    Done
  3. core-ci voted on patch set 2 V +1 02/19/24, 15:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53343

  4. Oliver Klee voted on patch set 2 CR +1 02/19/24, 15:33

  5. Markus Klein voted on patch set 2 CR +1 V +1 02/19/24, 16:14

  6. Jörg Bösche voted on patch set 2 CR +1 02/27/24, 08:14

  7. Georg Ringer voted on patch set 2 CR +1 V +1 06/25/24, 21:22

  8. Benni Mack commented on patch set 2 06/26/24, 05:27

    Reply

    Done
  9. Garvin Hicking voted on patch set 2 CR +1 V +1 07/03/24, 06:10

  10. Simon Schaufelberger voted on patch set 2 CR +1 V +1 07/08/24, 11:57

  11. Garvin Hicking commented on patch set 2 CR +2 V +2 10/15/24, 10:19

    Backport note Benni: Will be merged back to 11.5 as an exemption even no likely release for 11.5 will come up
  12. Garvin Hicking updated the commit message in patch set 3 CR +1 V +1 10/15/24, 10:46

  13. Garvin Hicking commented on patch set 3 10/15/24, 10:47

    Had to remove v11 backport. Revotes please ;-)
  14. core-ci voted on patch set 3 V -1 10/15/24, 10:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67832

  15. core-ci commented on patch set 3 10/15/24, 10:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67832

  16. core-ci commented on patch set 3 10/15/24, 11:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67832

  17. Garvin Hicking rebased onto patch set 4 V -1 10/15/24, 11:09

  18. core-ci voted on patch set 4 V +1 10/15/24, 11:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67835

  19. Simon Schaufelberger voted on patch set 4 CR +1 V +1 10/15/24, 11:32

  20. Georg Ringer voted on patch set 4 CR +1 V +1 10/16/24, 06:35

  21. Anja Leichsenring updated the commit message in patch set 5 CR +1 V +1 10/16/24, 06:44

  22. Anja Leichsenring voted on patch set 5 CR +1 V +1 10/16/24, 06:44

  23. core-ci voted on patch set 5 V +1 10/16/24, 06:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67868

  24. Garvin Hicking voted on patch set 5 CR +2 V +2 10/16/24, 07:04

  25. Garvin Hicking merged patch set 6 10/16/24, 07:04