Review main Merged

83005[BUGFIX] Add missing quotes to image processing suggestion

Torben Hansen CR +2 V +2 Easy +1 −1 updated 02/15/24, 09:36

Commit message

Install tool suggests to set
`$GLOBALS['TYPO3_CONF_VARS']['GFX']['processor_colorspace'] = sRGB`
if images appear too dark. In general this is the correct
suggestion, but the value must be quoted.

This change adds the missing single quotes for the value.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 810

  1. Torben Hansen uploaded patch set 1 02/15/24, 07:53

  2. core-ci voted on patch set 1 V +1 02/15/24, 07:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53214

  3. Christian Kuhn voted on patch set 1 CR +1 V +1 02/15/24, 08:36

  4. Andreas Kienast commented on patch set 1 02/15/24, 08:50

    ImageProcessing.html:20

    Strictly speaking, this needs a semicolon as well
  5. Torben Hansen uploaded patch set 2 CR +1 V +1 02/15/24, 08:54

  6. Torben Hansen commented on patch set 2 02/15/24, 08:55

    ImageProcessing.html:20 Reply

    Good catch, done.
  7. Andreas Kienast voted on patch set 2 CR +1 V +1 02/15/24, 08:56

  8. core-ci voted on patch set 2 V +1 02/15/24, 09:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53215

  9. Oli Bartsch voted on patch set 2 CR +2 V +2 02/15/24, 09:36

  10. Oli Bartsch merged patch set 3 02/15/24, 09:36