83009[BUGFIX] Prevent drop down menus in docheader from being cut off
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Jochen Roth +1
- Garvin Hicking +1
- Andreas Kienast +1
-
Verified V +2 Done
- Oli Bartsch +2
- Georg Ringer +1
- Jochen Roth +1
- Garvin Hicking +1
- Andreas Kienast +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1314
-
Oli Bartsch uploaded patch set 1 02/15/24, 10:17
-
core-ci voted on patch set 1 V +1 02/15/24, 10:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53224
-
Jochen Roth voted on patch set 1 CR +1 V +1 02/15/24, 10:30
-
Garvin Hicking commented on patch set 1 CR +1 V +1 02/16/24, 14:32
Works (tested macOS recent Chrome, Firefox, Safari, iOS)! :) (iOS has a bit of an issue when the page itself can't scroll and the location bar is on the bottom and I can't select the last 3 values of the dropdown. But can be remedied a bit by zooming or using landscape mode) -
Andreas Kienast commented on patch set 1 02/16/24, 16:11
_module.scss:112Perhaps we should use `100dvh` (this may solve Garvins iOS issue) -
Garvin Hicking commented on patch set 1 02/16/24, 16:41
_module.scss:112ReplyTried it with 100dvh but that doesn't make a difference (cleared caches and executed the CSS build, browser shows the change in effect) Here's a screenshot for what I mean. First one shows how the page looks, and I cannot scroll down because the content area is not large enough. I can however pull the scrollbar up (but can't click on the last items, because they "snap back"). Third screenshot shows that I can then select the entries once I zoom in: https://share.icloud.com/photos/09a6VLMpptIB2w_DbaYq6spfg -
Oli Bartsch commented on patch set 1 02/16/24, 16:58
_module.scss:112ReplySo, how should we proceed? -
Garvin Hicking commented on patch set 1 02/16/24, 17:06
_module.scss:112ReplyPersonally that iOS oddity doesn't disturb me too much, I'd merge this one?! -
Oli Bartsch commented on patch set 1 02/16/24, 17:11
_module.scss:112Replyall right. So resolving this comment and waiting for a core merger to vote. -
Georg Ringer commented on patch set 1 V +1 02/19/24, 07:45
works for me, but as I am certainly no FE dev, I am unsure if this is correct -
Andreas Kienast commented on patch set 1 CR -1 02/19/24, 08:01
on it -
Andreas Kienast voted on patch set 1 CR +1 V +1 02/19/24, 08:46
-
Oli Bartsch voted on patch set 1 CR +2 V +2 02/19/24, 17:00
-
Oli Bartsch merged patch set 2 02/19/24, 17:01