Review main Merged

83009[BUGFIX] Prevent drop down menus in docheader from being cut off

Oli Bartsch CR +2 V +2 Easy +6 −0 updated 02/19/24, 17:01

Commit message

Drop down menus, used in the docheader (e.g. the
language selection in then page module) do no longer
get cut off on small screens.

This is done by setting a dynamic max-height
(viewport height - topbar and docheader height)
and by allowing to scroll.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Garvin Hicking +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • Jochen Roth +1
    • Garvin Hicking +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1314

  1. Oli Bartsch uploaded patch set 1 02/15/24, 10:17

  2. core-ci voted on patch set 1 V +1 02/15/24, 10:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53224

  3. Jochen Roth voted on patch set 1 CR +1 V +1 02/15/24, 10:30

  4. Garvin Hicking commented on patch set 1 CR +1 V +1 02/16/24, 14:32

    Works (tested macOS recent Chrome, Firefox, Safari, iOS)! :) (iOS has a bit of an issue when the page itself can't scroll and the location bar is on the bottom and I can't select the last 3 values of the dropdown. But can be remedied a bit by zooming or using landscape mode)
  5. Andreas Kienast commented on patch set 1 02/16/24, 16:11

    _module.scss:112

    Perhaps we should use `100dvh` (this may solve Garvins iOS issue)
  6. Garvin Hicking commented on patch set 1 02/16/24, 16:41

    _module.scss:112 Reply

    Tried it with 100dvh but that doesn't make a difference (cleared caches and executed the CSS build, browser shows the change in effect) Here's a screenshot for what I mean. First one shows how the page looks, and I cannot scroll down because the content area is not large enough. I can however pull the scrollbar up (but can't click on the last items, because they "snap back"). Third screenshot shows that I can then select the entries once I zoom in: https://share.icloud.com/photos/09a6VLMpptIB2w_DbaYq6spfg
  7. Oli Bartsch commented on patch set 1 02/16/24, 16:58

    _module.scss:112 Reply

    So, how should we proceed?
  8. Garvin Hicking commented on patch set 1 02/16/24, 17:06

    _module.scss:112 Reply

    Personally that iOS oddity doesn't disturb me too much, I'd merge this one?!
  9. Oli Bartsch commented on patch set 1 02/16/24, 17:11

    _module.scss:112 Reply

    all right. So resolving this comment and waiting for a core merger to vote.
  10. Georg Ringer commented on patch set 1 V +1 02/19/24, 07:45

    works for me, but as I am certainly no FE dev, I am unsure if this is correct
  11. Andreas Kienast commented on patch set 1 CR -1 02/19/24, 08:01

    on it
  12. Andreas Kienast voted on patch set 1 CR +1 V +1 02/19/24, 08:46

  13. Oli Bartsch voted on patch set 1 CR +2 V +2 02/19/24, 17:00

  14. Oli Bartsch merged patch set 2 02/19/24, 17:01