Review main Merged

83010[TASK] Simplify DH->checkRecordUpdateAccess()

Christian Kuhn CR +2 V +2 Easy +24 −19 updated 02/15/24, 13:15

Commit message

Argument 3 $data of `checkRecordUpdateAccess()` is
funny: It is only used if argument 4 is given as
well. This is only done in method `process_datamap()`,
so `checkRecordUpdateAccess` hook method is
only triggered from within that method.

This situation allows us to move the hook call into
`process_datamap()` directly, making it more obvious
it's only triggered by that `main` method. This
allows us to get rid of arguments 3 and 4. Also
point out a logical issue within the method.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 812

  1. Christian Kuhn uploaded patch set 1 02/15/24, 10:51

  2. core-ci voted on patch set 1 V +1 02/15/24, 10:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53225

  3. Christian Kuhn uploaded patch set 2 V +1 02/15/24, 11:54

  4. Christian Kuhn updated the commit message in patch set 3 02/15/24, 11:56

  5. Oliver Klee updated the commit message in patch set 4 02/15/24, 11:59

  6. core-ci voted on patch set 2 V +1 02/15/24, 12:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53230

  7. core-ci voted on patch set 3 V +1 02/15/24, 12:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53231

  8. core-ci voted on patch set 4 V +1 02/15/24, 12:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53232

  9. Stefan Bürk voted on patch set 4 CR +1 V +1 02/15/24, 12:44

  10. Benni Mack voted on patch set 4 CR +1 V +1 02/15/24, 12:59

  11. Christian Kuhn voted on patch set 4 CR +2 V +2 02/15/24, 13:15

  12. Christian Kuhn merged patch set 5 02/15/24, 13:15