Review main Merged

83011[BUGFIX] Prevent TypeError in file related webhook messages

Oli Bartsch CR +2 V +2 Easy +3 −3 updated 02/16/24, 17:36

Commit message

Since FileInterface->getPublicUrl() might return
`NULL`, corresponding constructor arguments are
updated to now expect `?string`.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Oliver Klee +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Oliver Klee +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 67

  1. Oli Bartsch uploaded patch set 1 02/15/24, 11:04

  2. core-ci voted on patch set 1 V +1 02/15/24, 11:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53226

  3. Oliver Klee voted on patch set 1 CR +1 V +1 02/15/24, 11:18

  4. Andreas Kienast commented on patch set 1 02/16/24, 16:14

    Shouldn't phpstan have this detected earlier?
  5. Andreas Kienast voted on patch set 1 CR +1 V +1 02/16/24, 17:19

  6. Oli Bartsch voted on patch set 1 CR +2 V +2 02/16/24, 17:36

  7. Oli Bartsch merged patch set 2 02/16/24, 17:36