Review 11.5 Abandoned

83013[BUGFIX] Ensure translations are loaded from XLF before overriding with TypoScript

Markus Klein CR 0 V 0 Easy +9 −6 updated 10/31/24, 14:45

Commit message

Make sure label from TypoScript (_LOCAL_LANG) are
only loaded, if the according XLF file has been
processed beforehand.

The patch solves this by limiting the allowed
languages for TS labels to the ones currently
processed in that very call, as for those XLF
loading has been tried.

Note: It still works to define labels in TS
for languages not present in XLF files.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 917

  1. Markus Klein uploaded patch set 1 02/15/24, 13:47

  2. core-ci voted on patch set 1 V -1 02/15/24, 13:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53233

  3. Markus Klein marked it work in progress 02/15/24, 15:21

  4. Markus Klein uploaded patch set 2 V -1 02/15/24, 15:56

  5. core-ci voted on patch set 2 V -1 02/15/24, 16:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53237

  6. Markus Klein uploaded patch set 3 V -1 02/15/24, 16:34

  7. core-ci voted on patch set 3 V +1 02/15/24, 16:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53238

  8. Markus Klein updated the commit message in patch set 4 V +1 03/30/24, 21:13

  9. core-ci voted on patch set 4 V +1 03/30/24, 21:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55097

  10. Markus Klein updated the commit message in patch set 5 V +1 03/30/24, 21:32

  11. Markus Klein marked it ready for review 03/30/24, 21:32

  12. core-ci voted on patch set 5 V -1 03/30/24, 21:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55098

  13. Markus Klein rebased onto patch set 6 V -1 04/02/24, 13:42

  14. core-ci voted on patch set 6 V -1 04/02/24, 14:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55169

  15. core-ci commented on patch set 6 04/02/24, 15:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55169

  16. core-ci voted on patch set 6 V +1 04/02/24, 15:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/55169

  17. Benni Mack abandoned the change 10/31/24, 14:45

    I will abandon this change for v11, as we won't merge this into the public repo anymore, free v11.5 support ends today.