Review main Merged

83015[TASK] Remove unused DH $remapStackChildIds

Christian Kuhn CR +2 V +2 Easy +0 −26 updated 02/15/24, 15:39

Commit message

In this episode of 'Cracking the Cryptic' we are
looking at the DataHandler puzzle ;)
Let's get some obvious things done, first:

Protected property DataHandler->remapStackChildIds
is only written but never read. Remove property
and protected addNewValuesToRemapStackChildIds()
with all its callers to reduce complexity a bit.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Andreas Kienast +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 78

  1. Christian Kuhn uploaded patch set 1 02/15/24, 14:43

  2. core-ci voted on patch set 1 V +1 02/15/24, 14:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53235

  3. Andreas Kienast voted on patch set 1 CR +1 02/15/24, 14:51

  4. Andreas Kienast voted on patch set 1 V +1 02/15/24, 14:52

  5. Benni Mack voted on patch set 1 CR +1 V +1 02/15/24, 15:09

  6. Stefan Bürk voted on patch set 1 CR +1 V +1 02/15/24, 15:18

  7. Christian Kuhn voted on patch set 1 CR +2 V +2 02/15/24, 15:39

  8. Christian Kuhn merged patch set 2 02/15/24, 15:39