Review main Merged

83016[TASK] Remove unused DH $data_disableFields

Christian Kuhn CR +2 V +2 Easy +1 −11 updated 02/16/24, 10:11

Commit message

Similar to #103132. This time, public `@internal`
property $data_disableFields is only read, but
never written.

Reading the property comment, it looks as if this
may have been used as a detail scenario within
ext:impexp that has been removed long ago.

History reveals no core usage since ever: That
property hasn't even been used with Kaspers
initial commit in 2003.

Let's drop this artifact and keep it in versioning
museum forever.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • Andreas Kienast +1
    • Benni Mack +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • Andreas Kienast +1
    • Benni Mack +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 911

  1. Christian Kuhn uploaded patch set 1 02/15/24, 16:51

  2. core-ci voted on patch set 1 V +1 02/15/24, 16:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53239

  3. Christian Kuhn updated the commit message in patch set 2 V +1 02/15/24, 17:04

  4. Stefan Bürk voted on patch set 2 CR +1 V +1 02/15/24, 17:07

  5. core-ci voted on patch set 2 V +1 02/15/24, 17:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53240

  6. Oliver Klee voted on patch set 2 CR +1 V +1 02/15/24, 18:25

  7. Benni Mack voted on patch set 2 CR +1 V +1 02/15/24, 21:34

  8. Simon Schaufelberger commented on patch set 2 CR +1 V +1 02/15/24, 23:17

    let my vote be part of that museum commit 😊
  9. Andreas Kienast voted on patch set 2 CR +1 V +1 02/16/24, 07:25

  10. Christian Kuhn voted on patch set 2 CR +2 V +2 02/16/24, 10:10

  11. Christian Kuhn merged patch set 3 02/16/24, 10:11