83018[BUGFIX] Allow backend:user:create CLI Command to use shortcut options
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Stefan Bürk +1
-
Verified V +2 Done
- Benni Mack +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1215
-
Garvin Hicking uploaded patch set 1 02/16/24, 16:18
-
core-ci voted on patch set 1 V +1 02/16/24, 16:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53255
-
Stefan Bürk commented on patch set 1 02/16/24, 16:41
-
Garvin Hicking commented on patch set 1 02/16/24, 16:44
CreateBackendUserCommand.php:313ReplyYeah, I thought that was too much effort for options that can be inferred... But I was caught on my laziness. Will go the non-sneaky route next week. :-) -
Garvin Hicking commented on patch set 1 02/16/24, 16:48
CreateBackendUserCommand.php:313ReplyHm, wait. I'd need to pass along the shortcut option then to each command, like: $this->getFallbackValueEnvOrOption($input, 'email', 'e', 'TYPO3_BE_USER_EMAIL'); and that would create redundancy because the shortcut command would not only be set in $this->configure() but also at other places, that might be prone to errors. Do you know if Symfony Commands offer a way to retrieve the shortcut from a given option? I couldn't find this with a quick search on the $input-> getters. -
Stefan Bürk commented on patch set 1 02/16/24, 16:58
CreateBackendUserCommand.php:313Reply$optionDefinition = $this->getDefinition()->getOption('option'); $optionName = $optionDefinition->getName() $optionShortcut = $optionDefinition-->getShortcut() -
Garvin Hicking uploaded patch set 2
V +102/16/24, 19:40Properly evaluate shortcut -
Garvin Hicking commented on patch set 2 02/16/24, 19:41
CreateBackendUserCommand.php:313ReplyDone -
core-ci voted on patch set 2 V +1 02/16/24, 19:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53263
-
Stefan Bürk commented on patch set 2 CR -1 03/04/24, 18:10
CreateBackendUserCommand.php:310This does not respect the fact, that a option may not have a shortcut option set. If only a long-option is defined, `getShortcut()` returns `null`. Therefore the array like check below needs to be only enrichted with the shortcut option & the prefix if $optionShortcut is not null. -
Garvin Hicking uploaded patch set 3
CR -1V +103/04/24, 19:05 -
core-ci voted on patch set 3 V +1 03/04/24, 19:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53892
-
Stefan Bürk commented on patch set 3 CR +1 V +1 03/04/24, 19:42
CreateBackendUserCommand.php:310ReplyDone -
Benni Mack voted on patch set 3 CR +2 V +2 03/08/24, 18:27
-
Benni Mack merged patch set 4 03/08/24, 18:28
CreateBackendUserCommand.php:313