Review main Merged

83019[TASK] Clean up DataHandler

Christian Kuhn CR +2 V +2 Hard +355 −537 updated 02/16/24, 19:00

Commit message

Some cleanup of the class with obvious things:

* Add ConnectionPool, CacheManager and runtime cache as
  property, created in __construct(), can be DI later.
* Remove unused getResourceFactory(), remove
  getCacheManager() and getRuntimeCache() since they
  are properties now.
* Add type hints to most properties: Those that can be
  set without headaches since DH would crash if they'd
  not be of that type, or other obvious reasons.
* Turn a protected magic-string property into a constant
  and add another related constant to avoid a magic-string
  in code.
* Add a series of method return types: Obvious ones where
  the method clearly can't return something else.
* Minor comment spelling improvements.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 912

  1. Christian Kuhn uploaded patch set 1 02/16/24, 17:08

  2. core-ci voted on patch set 1 V +1 02/16/24, 17:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53256

  3. Christian Kuhn uploaded patch set 2 V +1 02/16/24, 17:33

  4. core-ci voted on patch set 2 V +1 02/16/24, 17:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53258

  5. Stefan Bürk commented on patch set 2 02/16/24, 18:16

    DataHandler.php:8863

    As we are on it, this method could safely get `:array` return type too.
  6. Christian Kuhn commented on patch set 2 02/16/24, 18:21

    DataHandler.php:8863 Reply

    Done
  7. Christian Kuhn uploaded patch set 3 V +1 02/16/24, 18:22

  8. core-ci voted on patch set 3 V +1 02/16/24, 18:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53261

  9. Stefan Bürk voted on patch set 3 CR +1 V +1 02/16/24, 18:29

  10. Anja Leichsenring voted on patch set 3 CR +1 V +1 02/16/24, 18:51

  11. Christian Kuhn voted on patch set 3 CR +2 V +2 02/16/24, 19:00

  12. Christian Kuhn merged patch set 4 02/16/24, 19:00