Review main Merged

83020[TASK] Remove DH $overrideValues and overrideFieldArray()

Christian Kuhn CR +2 V +2 Easy +0 −31 updated 02/16/24, 19:24

Commit message

This `@internal` property and method is another "has
never been used" detail: It dates back to very early
TYPO3 versions and TER reveals not a single usage.

In case there are still extensions dealing with that
public property, it should be possible to use hook
'processDatamap_postProcessFieldArray' instead, which
is dispatched within process_datamap() a couple of
lines later.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 79

  1. Christian Kuhn uploaded patch set 1 02/16/24, 18:20

  2. core-ci voted on patch set 1 V +1 02/16/24, 18:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53259

  3. Stefan Bürk voted on patch set 1 CR +1 V +1 02/16/24, 18:31

  4. Christian Kuhn uploaded patch set 2 CR +1 V +1 02/16/24, 19:02

  5. Stefan Bürk voted on patch set 2 CR +1 V +1 02/16/24, 19:03

  6. core-ci voted on patch set 2 V +1 02/16/24, 19:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53262

  7. Anja Leichsenring voted on patch set 2 CR +1 V +1 02/16/24, 19:20

  8. Christian Kuhn voted on patch set 2 CR +2 V +2 02/16/24, 19:23

  9. Christian Kuhn merged patch set 3 02/16/24, 19:24